linux-kernel - Re: [PATCH v1 net-next] net: lan743x: configure interrupt moderation timers based on speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250506175441.695f97fd@kernel.org>
Date: Tue, 6 May 2025 17:54:41 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Thangaraj.S@...rochip.com
Cc: Andrew Lunn <andrew@...n.ch>, Bryan.Whitehead@...rochip.com,
 andrew+netdev@...n.ch, davem@...emloft.net, linux-kernel@...r.kernel.org,
 pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org,
 UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v1 net-next] net: lan743x: configure interrupt
 moderation timers based on speed

On Tue, 6 May 2025 14:10:09 +0200 Andrew Lunn wrote:
> > We've tuned the interrupt moderation values based on testing to improve
> > performance. For now, we’ll keep these fixed values optimized for
> > performance across all speeds. That said, we agree that adding ethtool
> > -c/-C support would provide valuable flexibility for users to balance
> > power and performance, and we’ll consider implementing that in a future
> > update.  
> 
> As you said, you have optimised for performance. That might cause
> regressions for some users. We try to avoid regressions, and if
> somebody does report a regression, we will have to revert this change.
> If you were to implement this ethtool option, we are a lot less likely
> to make a revert, we can instruct the user how to set the coalesce for
> there use case.

I completely agree. Please let the users decide how they want to balance
throughput vs latency.
-- 
pw-bot: cr