linux-kernel - Re: [PATCH v1 net-next] net: lan743x: configure interrupt moderation timers based on speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32159cd4a320a492fd47b6c38cebdb9a994c8bf5.camel@microchip.com>
Date: Thu, 8 May 2025 03:36:17 +0000
From: <Thangaraj.S@...rochip.com>
To: <kuba@...nel.org>
CC: <Bryan.Whitehead@...rochip.com>, <andrew+netdev@...n.ch>,
	<davem@...emloft.net>, <andrew@...n.ch>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH v1 net-next] net: lan743x: configure interrupt moderation
 timers based on speed

Hi Andrew & Jakub,
Thanks for reviewing the patch.

I agree with your comments and will implement the ethtool option to
provide flexibility, while keeping the default behavior as defined in
this patch based on speed.

Thanks,
Thangaraj Samynathan
On Tue, 2025-05-06 at 17:54 -0700, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Tue, 6 May 2025 14:10:09 +0200 Andrew Lunn wrote:
> > > We've tuned the interrupt moderation values based on testing to
> > > improve
> > > performance. For now, we’ll keep these fixed values optimized for
> > > performance across all speeds. That said, we agree that adding
> > > ethtool
> > > -c/-C support would provide valuable flexibility for users to
> > > balance
> > > power and performance, and we’ll consider implementing that in a
> > > future
> > > update.
> > 
> > As you said, you have optimised for performance. That might cause
> > regressions for some users. We try to avoid regressions, and if
> > somebody does report a regression, we will have to revert this
> > change.
> > If you were to implement this ethtool option, we are a lot less
> > likely
> > to make a revert, we can instruct the user how to set the coalesce
> > for
> > there use case.
> 
> I completely agree. Please let the users decide how they want to
> balance
> throughput vs latency.
> --
> pw-bot: cr