linux-kernel - Re: [PATCH v4 08/31] x86/resctrl: Move L3 initialization out of domain_add_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35bd96ef-db73-4ab5-a904-e91777c2a5f2@intel.com>
Date: Wed, 7 May 2025 20:37:10 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Anil Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v4 08/31] x86/resctrl: Move L3 initialization out of
 domain_add_cpu_mon()

Hi Tony,

On 4/28/25 5:33 PM, Tony Luck wrote:
> To prepare for additional types of monitoring domains, move all the
> L3 specific initialization into a helper function.

Please make this specific. "L3 specific initialization" covers quite a
bit ... from the L3 resource control and monitoring enumeration done in
arch code to the per domain initialization done during CPU online for
control and monitoring. Small change like "L3 resource monitoring domain
initialization" would already be more descriptive, but please feel free
to improve.

> 
> Rename several functions to mark that they are specific to the L3 path.
> 
> arch_mon_domain_online	-> arch_l3_mon_domain_online
> mon_domain_free		-> free_l3_mon_domain

Wouldn't "l3_mon_domain_free()" be better match for the "online" variant?

I think it will be helpful to reviewer to mention that the new
"helper function" is named setup_l3_mon_domain() (l3_mon_domain_setup()?)
and is the partner of the renamed "free" function.

> arch_mon_domain_online	-> arch_l3_mon_domain_online
duplicate

> domain_setup_mon_state	-> domain_setup_l3_mon_state

See "Function references in changelogs" in 
Documentation/process/maintainer-tip.rst

> 
> resctrl_online_mon_domain() is going to share some code with new
> reources, so keeps the same name, but include a check for

reources -> resources
keeps -> keep

> RDT_RESOURCE_L3.

Reinette