linux-kernel - Re: [PATCH v4] bus: mhi: host: don't free bhie tables during suspend/hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3725aa4-ed50-447a-b396-6d3a79bdef99@quicinc.com>
Date: Wed, 7 May 2025 17:14:14 +0800
From: Baochen Qiang <quic_bqiang@...cinc.com>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>,
        Jeff Johnson <jjohnson@...nel.org>,
        "Jeff
 Hugo" <jeff.hugo@....qualcomm.com>,
        Youssef Samir
	<quic_yabdulra@...cinc.com>,
        Matthew Leung <quic_mattleun@...cinc.com>,
        Yan
 Zhen <yanzhen@...o.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>,
        Kunwu Chan
	<chentao@...inos.cn>,
        "Troy Hanson" <quic_thanson@...cinc.com>,
        "Dr. David
 Alan Gilbert" <linux@...blig.org>
CC: <kernel@...labora.com>, <sebastian.reichel@...labora.com>,
        Carl Vanderlip
	<quic_carlv@...cinc.com>,
        Alex Elder <elder@...nel.org>, <mhi@...ts.linux.dev>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-wireless@...r.kernel.org>, <ath11k@...ts.infradead.org>,
        <ath12k@...ts.infradead.org>
Subject: Re: [PATCH v4] bus: mhi: host: don't free bhie tables during
 suspend/hibernation



On 5/6/2025 10:49 PM, Muhammad Usama Anjum wrote:
> Fix dma_direct_alloc() failure at resume time during bhie_table
> allocation because of memory pressure. There is a report where at
> resume time, the memory from the dma doesn't get allocated and MHI
> fails to re-initialize.
> 
> To fix it, don't free the memory at power down during suspend /
> hibernation. Instead, use the same allocated memory again after every
> resume / hibernation. This patch has been tested with resume and
> hibernation both.
> 
> The rddm is of constant size for a given hardware. While the fbc_image
> size depends on the firmware. If the firmware changes, we'll free and
> allocate new memory for it.
> 
> Tested-on: WCN6855 WLAN.HSP.1.1-03926.13-QCAHSPSWPL_V2_SILICONZ_CE-2.52297.6
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

with WLAN firmware unchanged, suspend/resume is working well:

Tested-on: WCN7850 hw2.0 WLAN.HMT.1.1.c5-00284-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Tested-by: Baochen Qiang <quic_bqiang@...cinc.com>