linux-kernel - Re: [PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e4d3127af2e2ace3fcec73eb8903c12ebcdda38.camel@ew.tq-group.com>
Date: Wed, 07 May 2025 11:51:25 +0200
From: Matthias Schiffer <matthias.schiffer@...tq-group.com>
To: Roger Quadros <rogerq@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Andy Whitcroft <apw@...onical.com>, "mike .."
 <wingman205@....com>, Dwaipayan Ray <dwaipayanray1@...il.com>, Lukas
 Bulwahn <lukas.bulwahn@...il.com>, Joe Perches <joe@...ches.com>, Jonathan
 Corbet <corbet@....net>, Nishanth Menon <nm@...com>, Vignesh Raghavendra
 <vigneshr@...com>, Siddharth Vadapalli <s-vadapalli@...com>, Tero Kristo
 <kristo@...nel.org>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org,  netdev@...r.kernel.org,
 devicetree@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
 linux@...tq-group.com
Subject: Re: [PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss:
 update phy-mode in example

On Wed, 2025-04-30 at 17:22 +0300, Roger Quadros wrote:
> 
> Hi Matthias,
> 
> On 15/04/2025 13:18, Matthias Schiffer wrote:
> > k3-am65-cpsw-nuss controllers have a fixed internal TX delay, so RXID
> > mode is not actually possible and will result in a warning from the
> > driver going forward.
> > 
> > Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> > ---
> >  .../devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml          | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> > index b11894fbaec47..c8128b8ca74fb 100644
> > --- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> > +++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> > @@ -282,7 +282,7 @@ examples:
> >                      ti,syscon-efuse = <&mcu_conf 0x200>;
> >                      phys = <&phy_gmii_sel 1>;
> >  
> > -                    phy-mode = "rgmii-rxid";
> > +                    phy-mode = "rgmii-id";
> >                      phy-handle = <&phy0>;
> >                  };
> >              };
> 
> FYI the following TI boards using this driver are using "rgmii-rxid".
> Will you be sending fixes to the device trees files?

Hi Roger,

as written in the cover letter, I haven't fixed any DTS for now, so projects
consuming Linux's Device Tree sources (like U-Boot) have some time to update
their driver first (as fixing the Device Trees without updating the driver would
break Ethernet).

Once a fix has been accepted in U-Boot (and preferably after we've come to an
agreement on the open questions...) I can also send a patch to update these
files.

Best,
Matthias

> 
> arch/arm64/boot/dts/ti
> k3-am625-beagleplay.dts:	phy-mode = "rgmii-rxid";
> k3-am625-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am625-sk.dts.orig:	phy-mode = "rgmii-rxid";
> k3-am62a7-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am62a-phycore-som.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62p5-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am62p5-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am62-phycore-som.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62-verdin-dev.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62-verdin.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62-verdin-ivy.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62x-phyboard-lyra.dtsi:	phy-mode = "rgmii-rxid";
> k3-am62x-sk-common.dtsi:	phy-mode = "rgmii-rxid";
> k3-am642-evm.dts:	phy-mode = "rgmii-rxid";
> k3-am642-evm.dts:	phy-mode = "rgmii-rxid";
> k3-am642-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am642-sk.dts:	phy-mode = "rgmii-rxid";
> k3-am642-tqma64xxl-mbax4xxl.dts:	phy-mode = "rgmii-rxid";
> k3-am642-tqma64xxl-mbax4xxl.dts:	/* phy-mode is fixed up to rgmii-rxid by prueth driver to account for
> k3-am64-phycore-som.dtsi:	phy-mode = "rgmii-rxid";
> k3-am654-base-board.dts:	phy-mode = "rgmii-rxid";
> k3-am67a-beagley-ai.dts:	phy-mode = "rgmii-rxid";
> k3-am68-sk-base-board.dts:	phy-mode = "rgmii-rxid";
> k3-am69-sk.dts:	phy-mode = "rgmii-rxid";
> k3-j7200-common-proc-board.dts:	phy-mode = "rgmii-rxid";
> k3-j721e-beagleboneai64.dts:	phy-mode = "rgmii-rxid";
> k3-j721e-common-proc-board.dts:	phy-mode = "rgmii-rxid";
> k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
> k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
> k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
> k3-j721e-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
> k3-j721e-sk.dts:	phy-mode = "rgmii-rxid";
> k3-j721s2-common-proc-board.dts:	phy-mode = "rgmii-rxid";
> k3-j721s2-evm-gesi-exp-board.dtso:	phy-mode = "rgmii-rxid";
> k3-j722s-evm.dts:	phy-mode = "rgmii-rxid";
> k3-j784s4-j742s2-evm-common.dtsi:	phy-mode = "rgmii-rxid";
> k3-j784s4-j742s2-evm-common.dtsi:	phy-mode = "rgmii-rxid";
> 

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/