linux-kernel - Re: [PATCH net-next 4/4] checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba1fba45aef0264d1215c3abac1d74e3ad2c33f2.camel@ew.tq-group.com>
Date: Tue, 24 Jun 2025 11:50:35 +0200
From: Matthias Schiffer <matthias.schiffer@...tq-group.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Andy
 Whitcroft <apw@...onical.com>, Dwaipayan Ray <dwaipayanray1@...il.com>,
 Lukas Bulwahn <lukas.bulwahn@...il.com>, Joe Perches <joe@...ches.com>,
 Jonathan Corbet <corbet@....net>, Nishanth Menon <nm@...com>,  Vignesh
 Raghavendra <vigneshr@...com>, Siddharth Vadapalli <s-vadapalli@...com>,
 Roger Quadros <rogerq@...nel.org>, Tero Kristo <kristo@...nel.org>,
 linux-doc@...r.kernel.org,  linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, linux@...tq-group.com
Subject: Re: [PATCH net-next 4/4] checkpatch: check for comment explaining
 rgmii(|-rxid|-txid) PHY modes

On Tue, 2025-04-15 at 15:12 +0200, Andrew Lunn wrote:
> 
> > My Perl-fu isn't good enough for me to review this properly... I think
> > though that Andrew mentioned something along the lines of 'Comment
> > should include PCB somewhere', but I don't know if this is easily
> > doable with checkpatch though.
> 
> Maybe make it into a patchset, and change a few DTS files to match the
> condition. e.g.
> 
> arm/boot/dts/nxp/ls/ls1021a-tsn.dts:/* RGMII delays added via PCB traces */
> arm/boot/dts/nxp/ls/ls1021a-tsn.dts-&enet2 {
> arm/boot/dts/nxp/ls/ls1021a-tsn.dts-    phy-mode = "rgmii";
> arm/boot/dts/nxp/ls/ls1021a-tsn.dts-    status = "okay";
> 
> This example is not great, but...
> arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi-                         phy-mode = "rgmii";
> arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi:                         /* 2ns RX delay is implemented on PCB */
> arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi-                         tx-internal-delay-ps = <2000>;
> arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi-                         rx-internal-delay-ps = <0>;
> 
> There is one more i know of somewhere which i cannot find at the
> moment which uses rgmii-rxid or rgmii-txid, an has a comment about
> delay.
> 
> 	Andrew

FWIW, I've decided against including the comment changes in this series for now
(going to send a v2 in a moment), as non-functional changes just to improve
style or make checkpatch happy are often frowned upon as unnecessary churn.

Best,
Matthias

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/