linux-kernel - Re: [PATCH v10 4/7] can: Add Nuvoton NCT6694 CANFD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250508-prudent-festive-puffin-83f666-mkl@pengutronix.de>
Date: Thu, 8 May 2025 17:08:15 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Ming Yu <a0282524688@...il.com>
Cc: lee@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl, 
	andi.shyti@...nel.org, mailhol.vincent@...adoo.fr, andrew+netdev@...n.ch, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	wim@...ux-watchdog.org, linux@...ck-us.net, jdelvare@...e.com, 
	alexandre.belloni@...tlin.com, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-i2c@...r.kernel.org, linux-can@...r.kernel.org, netdev@...r.kernel.org, 
	linux-watchdog@...r.kernel.org, linux-hwmon@...r.kernel.org, linux-rtc@...r.kernel.org, 
	linux-usb@...r.kernel.org, Ming Yu <tmyu0@...oton.com>
Subject: Re: [PATCH v10 4/7] can: Add Nuvoton NCT6694 CANFD support

On 08.05.2025 11:26:09, Ming Yu wrote:
> > > This driver supports Socket CANFD functionality for NCT6694 MFD
> > > device based on USB interface.
> > >
> > > Signed-off-by: Ming Yu <tmyu0@...oton.com>
> >
> > The destroy functions nct6694_canfd_close() and nct6694_canfd_remove()
> > are not the exact inverse of their init functions. Se comments inline.
> >
> > Please fix and add:
> >
> > Reviewed-by: Marc Kleine-Budde <mkl@...gutronix.de>
> >
> > Feel free to mainline this patch as part of the series outside of the
> > linux-can-next tree. Better ask the netdev maintainers for their OK, too.
> >
> > What about transceiver delay compensation for higher CAN-FD bitrates?
> > How does you device handle these?
> >
> 
> In the CAN CMD0's DBTP field, bit 23 is the TDC flag, I will add
> support for enabling tdc, and firmware will automatically configure
> tdco. Do you think this approach is appropriate?

Can you configure the TDC manually via USB?

If the firmware does automatic TDCO configuration, does it take care of
not enabling TCDO if the Data-BRP is > 2?

BTW: What's the CAN clock of the device? I want to add it to the
can-utils' bitrate calculation tool.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)