lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4273451f-5edb-4d39-86b9-022456bba950@linux.microsoft.com>
Date: Thu, 8 May 2025 08:09:22 -0700
From: Roman Kisel <romank@...ux.microsoft.com>
To: Michael Kelley <mhklinux@...look.com>
Cc: "apais@...rosoft.com" <apais@...rosoft.com>,
 "benhill@...rosoft.com" <benhill@...rosoft.com>,
 "bperkins@...rosoft.com" <bperkins@...rosoft.com>,
 "sunilmut@...rosoft.com" <sunilmut@...rosoft.com>,
 "ardb@...nel.org" <ardb@...nel.org>, "bp@...en8.de" <bp@...en8.de>,
 "brgerst@...il.com" <brgerst@...il.com>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
 "decui@...rosoft.com" <decui@...rosoft.com>,
 "dimitri.sivanich@....com" <dimitri.sivanich@....com>,
 "gautham.shenoy@....com" <gautham.shenoy@....com>,
 "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>,
 "hpa@...or.com" <hpa@...or.com>,
 "imran.f.khan@...cle.com" <imran.f.khan@...cle.com>,
 "jacob.jun.pan@...ux.intel.com" <jacob.jun.pan@...ux.intel.com>,
 "jpoimboe@...nel.org" <jpoimboe@...nel.org>,
 "justin.ernst@....com" <justin.ernst@....com>,
 "kprateek.nayak@....com" <kprateek.nayak@....com>,
 "kyle.meyer@....com" <kyle.meyer@....com>,
 "kys@...rosoft.com" <kys@...rosoft.com>, "lenb@...nel.org"
 <lenb@...nel.org>, "mingo@...hat.com" <mingo@...hat.com>,
 "nikunj@....com" <nikunj@....com>, "papaluri@....com" <papaluri@....com>,
 "patryk.wlazlyn@...ux.intel.com" <patryk.wlazlyn@...ux.intel.com>,
 "peterz@...radead.org" <peterz@...radead.org>,
 "rafael@...nel.org" <rafael@...nel.org>,
 "russ.anderson@....com" <russ.anderson@....com>,
 "sohil.mehta@...el.com" <sohil.mehta@...el.com>,
 "steve.wahl@....com" <steve.wahl@....com>,
 "tglx@...utronix.de" <tglx@...utronix.de>,
 "thomas.lendacky@....com" <thomas.lendacky@....com>,
 "tiala@...rosoft.com" <tiala@...rosoft.com>,
 "wei.liu@...nel.org" <wei.liu@...nel.org>,
 "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
 "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
 "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH hyperv-next 0/2] arch/x86, x86/hyperv: Few fixes for the
 AP startup



On 5/7/2025 9:22 PM, Michael Kelley wrote:
> From: Roman Kisel <romank@...ux.microsoft.com> Sent: Wednesday, May 7, 2025 11:22 AM
[...]>
> I think this works. It's unfortunate that Patch 1 adds 11 lines of code/comments that
> Patch 2 then deletes, which seems like undesirable churn. I was expecting adding the
> "cpu" parameter to come first, which then makes fixing the hv_snp_boot_ap() problem
> more straightforward. But looking more closely, hv_snp_boot_ap() already has a
> parameter erroneously named "cpu", so adding the correct "cpu" parameter isn't
> transparent. Hence the order you've chosen is probably the best resolution for a
> messy situation. :-)

Thanks, Michael :) Looked as a good trade-off, went ahead with it. Will
be happy to address any concerns of that folks might have!

> 
> Michael
> 
>>
>>   arch/x86/coco/sev/core.c             | 13 ++-----
>>   arch/x86/hyperv/hv_init.c            | 33 +++++++++++++++++
>>   arch/x86/hyperv/hv_vtl.c             | 54 ++++------------------------
>>   arch/x86/hyperv/ivm.c                | 11 ++++--
>>   arch/x86/include/asm/apic.h          |  8 ++---
>>   arch/x86/include/asm/mshyperv.h      |  7 ++--
>>   arch/x86/kernel/acpi/madt_wakeup.c   |  2 +-
>>   arch/x86/kernel/apic/apic_noop.c     |  8 ++++-
>>   arch/x86/kernel/apic/apic_numachip.c |  2 +-
>>   arch/x86/kernel/apic/x2apic_uv_x.c   |  2 +-
>>   arch/x86/kernel/smpboot.c            | 10 +++---
>>   include/hyperv/hvgdk_mini.h          |  2 +-
>>   12 files changed, 76 insertions(+), 76 deletions(-)
>>
>>
>> base-commit: 9b0844d87b1407681b78130429f798beb366f43f
>> --
>> 2.43.0
> 

-- 
Thank you,
Roman


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ