linux-kernel - Re: The "make headers" requirement, revisited: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b547d83f-6e9d-4b11-9207-aca8fd575794@linuxfoundation.org>
Date: Thu, 8 May 2025 09:06:41 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Sean Christopherson <seanjc@...gle.com>
Cc: John Hubbard <jhubbard@...dia.com>, Peter Zijlstra
 <peterz@...radead.org>, Shuah Khan <shuah@...nel.org>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>,
 Suren Baghdasaryan <surenb@...gle.com>, Vlastimil Babka <vbabka@...e.cz>,
 pedro.falcato@...il.com, linux-kselftest@...r.kernel.org,
 linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
 linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
 Oliver Sang <oliver.sang@...el.com>, Christian Brauner
 <christian@...uner.io>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: The "make headers" requirement, revisited: [PATCH v3 3/3]
 selftests: pidfd: add tests for PIDFD_SELF_*

On 5/8/25 08:04, Sean Christopherson wrote:
> On Wed, May 07, 2025, Shuah Khan wrote:
>> The issues Peter is seeing regarding KHDR_INCLUDES in the following
>> tests can be easily fixed by simply changing the test Makefile. These
>> aren't framework related.
>>
>> kvm/Makefile.kvm:    -I ../rseq -I.. $(EXTRA_CFLAGS) $(KHDR_INCLUDES)
> 
> ...
> 
>> You can make the change to remove the reference to KHDR_INCLUDES.
>> If don't have the time/bandwidth to do it, I will take care of it.
> 
> Please don't remove the KHDR_INCLUDES usage in KVM's selftests, KVM routinely
> adds tests for new uAPI.  Having to manually install headers is annoying, but
> IMO it's the least awful solution we have.

Thank you for confirming that KHDR_INCLUDES customization is necessary
for some tests such as kvm.

thanks,
-- Shuah