linux-kernel - Re: [PATCH][V2][next] ASoC: rt712-sdca: remove redundant else path of if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1f5fa12-1e0d-429c-bc15-79911c2571d1@gmail.com>
Date: Thu, 8 May 2025 16:17:42 +0100
From: "Colin King (gmail)" <colin.i.king@...il.com>
To: Mark Brown <broonie@...nel.org>, Oder Chiou <oder_chiou@...ltek.com>,
 Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, linux-sound@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
 christophe.jaillet@...adoo.fr
Subject: Re: [PATCH][V2][next] ASoC: rt712-sdca: remove redundant else path of
 if statement

Hi Mark,

Looking at your repo I think you applied the V1 of the patch and not the 
V2.

Colin

On 08/05/2025 15:39, Mark Brown wrote:
> On Thu, 08 May 2025 09:45:27 +0100, Colin Ian King wrote:
>> There is an if/else check where the else part is executed if
>> adc_vol_flag is true, this else path checks if adc_vol_flag
>> is true (which is a redundant second check) and the if path is
>> always taken. Remove the redundant check and remove the else
>> path since that can never occur.
>>
>>
>> [...]
> 
> Applied to
> 
>     https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/1] ASoC: rt712-sdca: remove redundant else path of if statement
>        commit: 8147e75bd5f0977f6d389f6cdb4f10956cc3d88f
> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
> 
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
> 
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
> 
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
> 
> Thanks,
> Mark
> 


Download attachment "OpenPGP_0x68C287DFC6A80226.asc" of type "application/pgp-keys" (4825 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)