linux-kernel - Re: [PATCH] PCI/bwctrl: Remove unused pcie_bwctrl_lbms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <606a5ead-1fcf-43a4-94d3-5d8c1e70dd92@paulmck-laptop>
Date: Thu, 8 May 2025 08:14:07 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: ilpo.jarvinen@...ux.intel.com, bhelgaas@...gle.com,
	linux-pci@...r.kernel.org, kernel-team@...a.com,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org
Subject: Re: [PATCH] PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem

On Thu, May 08, 2025 at 07:08:45PM +1000, Stephen Rothwell wrote:
> Hi Paul,
> 
> On Wed, 7 May 2025 15:04:57 -0700 "Paul E. McKenney" <paulmck@...nel.org> wrote:
> >
> > PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem
> > 
> > Builds with CONFIG_PREEMPT_RT=y get the following build error:
> > 
> > drivers/pci/pcie/bwctrl.c:56:22: error: ‘pcie_bwctrl_lbms_rwsem’ defined but not used [-Werror=unused-variable]
> > 
> > Therefore, remove this unused variable.  Perhaps this should be folded
> > into the commit shown below.
> > 
> > Fixes: 0238f352a63a ("PCI/bwctrl: Replace lbms_count with PCI_LINK_LBMS_SEEN flag")
> > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > Cc: "Ilpo Järvinen" <ilpo.jarvinen@...ux.intel.com>
> > Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> > Cc: <linux-pci@...r.kernel.org>
> > 
> > diff --git a/drivers/pci/pcie/bwctrl.c b/drivers/pci/pcie/bwctrl.c
> > index fdafa20e4587d..841ab8725aff7 100644
> > --- a/drivers/pci/pcie/bwctrl.c
> > +++ b/drivers/pci/pcie/bwctrl.c
> > @@ -53,7 +53,6 @@ struct pcie_bwctrl_data {
> >   * (using just one rwsem triggers "possible recursive locking detected"
> >   * warning).
> >   */
> > -static DECLARE_RWSEM(pcie_bwctrl_lbms_rwsem);
> >  static DECLARE_RWSEM(pcie_bwctrl_setspeed_rwsem);
> >  
> >  static bool pcie_valid_speed(enum pci_bus_speed speed)
> 
> I added that to linux-next today and will remove it when it is no
> longer needed.

Thank you, Stephen!

Ilpo, I look forward to seeing this patch replaced by your improved
version with better comments.

							Thanx, Paul