linux-kernel - Re: [PATCH net v4 1/2] net: dsa: microchip: let phylink manage PHY EEE configuration on KSZ switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c993748c-18ba-4dad-9130-01ac35322491@redhat.com>
Date: Thu, 8 May 2025 12:30:56 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
 Eric Dumazet <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>,
 Jakub Kicinski <kuba@...nel.org>, Vladimir Oltean <olteanv@...il.com>,
 Woojung Huh <woojung.huh@...rochip.com>,
 "Russell King (Oracle)" <linux@...linux.org.uk>,
 Heiner Kallweit <hkallweit1@...il.com>
Cc: stable@...r.kernel.org, kernel@...gutronix.de,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net v4 1/2] net: dsa: microchip: let phylink manage PHY
 EEE configuration on KSZ switches

On 5/4/25 10:14 AM, Oleksij Rempel wrote:
> Phylink expects MAC drivers to provide LPI callbacks to properly manage
> Energy Efficient Ethernet (EEE) configuration. On KSZ switches with
> integrated PHYs, LPI is internally handled by hardware, while ports
> without integrated PHYs have no documented MAC-level LPI support.
> 
> Provide dummy mac_disable_tx_lpi() and mac_enable_tx_lpi() callbacks to
> satisfy phylink requirements. Also, set default EEE capabilities during
> phylink initialization where applicable.
> 
> Since phylink can now gracefully handle optional EEE configuration,
> remove the need for the MICREL_NO_EEE PHY flag.
> 
> This change addresses issues caused by incomplete EEE refactoring
> introduced in commit fe0d4fd9285e ("net: phy: Keep track of EEE
> configuration"). It is not easily possible to fix all older kernels, but
> this patch ensures proper behavior on latest kernels and can be
> considered for backporting to stable kernels starting from v6.14.
> 
> Fixes: fe0d4fd9285e ("net: phy: Keep track of EEE configuration")
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> Cc: stable@...r.kernel.org # v6.14+

It would be great if either a phy maintainer could have a look here.

Thanks,

Paolo