linux-kernel - Re: [PATCH v4 01/25] media: iris: Skip destroying internal buffer if not dequeued

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38cea95a-aeac-c20d-8175-7a521d917021@quicinc.com>
Date: Thu, 8 May 2025 15:59:25 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Vikash Garodia
	<quic_vgarodia@...cinc.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        Hans Verkuil
	<hverkuil@...all.nl>,
        Stefan Schmidt <stefan.schmidt@...aro.org>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@....qualcomm.com>,
        Neil Armstrong
	<neil.armstrong@...aro.org>,
        Nicolas Dufresne
	<nicolas.dufresne@...labora.com>,
        Dan Carpenter <dan.carpenter@...aro.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH v4 01/25] media: iris: Skip destroying internal buffer if
 not dequeued



On 5/7/2025 8:37 PM, Bryan O'Donoghue wrote:
> On 07/05/2025 08:39, Dikshita Agarwal wrote:
>> Firmware might hold the DPB buffers for reference in case of sequence
>> change, so skip destroying buffers for which QUEUED flag is not removed.
>> Also, make sure that all buffers are released during streamoff.
>>
>> Cc: stable@...r.kernel.org
>> Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue
>> internal buffers")
>> Reviewed-by: Vikash Garodia <quic_vgarodia@...cinc.com>
>> Signed-off-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
> 
> I'll take your word for it on firmware respecting the software contract on
> close() wrt to DMA - however I think you should split this patch into two
> separate patches along the lines of the "also" in your commit log.
> 
> 1. Skip destroying buffers for QUEUED flag
> 2. Make sure all buffers are released during stream off
> 
> These are two separate fixes IMO.
Sure will split.

Please let me know if you have any other comments
if no comments, will send v5 with addressing above.

Thanks,
Dikshita
> 
> ---
> bod