linux-kernel - Re: [PATCH V11 00/15] Rust abstractions for clk, cpumask, cpufreq, OPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohponbEEP4_weUuKkOGLRj5-1oOsoL_Zu_7W_SxB61hjsSCw@mail.gmail.com>
Date: Thu, 8 May 2025 07:40:26 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Philip Li <philip.li@...el.com>, 
	kbuild test robot <lkp@...el.com>
Cc: Andrew Ballance <andrewjballance@...il.com>, a.hindborg@...nel.org, 
	alex.bennee@...aro.org, alex.gaynor@...il.com, aliceryhl@...gle.com, 
	anisse@...ier.eu, benno.lossin@...ton.me, bjorn3_gh@...tonmail.com, 
	boqun.feng@...il.com, bqe@...gle.com, dakr@...nel.org, dakr@...hat.com, 
	daniel.almeida@...labora.com, gary@...yguo.net, joakim.bech@...aro.org, 
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org, linux@...linux.org.uk, linux@...musvillemoes.dk, 
	manos.pitsidianakis@...aro.org, mturquette@...libre.com, nm@...com, 
	ojeda@...nel.org, peterz@...radead.org, rafael@...nel.org, robh@...nel.org, 
	rust-for-linux@...r.kernel.org, sboyd@...nel.org, tglx@...utronix.de, 
	tmgross@...ch.edu, vincent.guittot@...aro.org, vireshk@...nel.org, 
	yury.norov@...il.com
Subject: Re: [PATCH V11 00/15] Rust abstractions for clk, cpumask, cpufreq, OPP

I am on holidays right now with limited access, there may be
delay in my responses.

On Tue, 6 May 2025 at 15:55, Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Tue, May 6, 2025 at 12:15 PM Andrew Ballance
> <andrewjballance@...il.com> wrote:
> >
> > I have tried building the latest linux-next and I think that this
> > patch series causes a build error with the defconfig for x86_64.

Thanks for the report Andrew. I was expecting to get
these from LKP (for my branch [1]) but I didn't. Even if
my branch isn't getting tested for Rust currently (please
enable that Philip), I should have received these for
linux-next ? Philip ?

Anyway, I have prepared a branch with a fix for this, but
facing issues with pushing my branch on git.kernel.org
currently (Don't have my regular work setup while traveling).

> Yeah, I also see it in the latest `linux-next` runs.
>
> And in arm64, it builds, but I see a doctest failure too:
>
> [    1.014106]     # rust_doctest_kernel_cpumask_rs_0.location:
> rust/kernel/cpumask.rs:180
> [    1.015226]     # rust_doctest_kernel_cpumask_rs_0: ASSERTION
> FAILED at rust/kernel/cpumask.rs:190
> [    1.015226]     Expected mask.weight() == 2 to be true, but is false
> [    1.017326]     not ok 40 rust_doctest_kernel_cpumask_rs_0

That's strange. I have tested this earlier and made sure such issues
weren't there. I tried "next-20250507" now for arm64 (with qemu)
with and without CONFIG_CPUMASK_OFFSTACK and still don't
see these issues.

[    0.000000] Linux version 6.15.0-rc5-next-20250507
(vireshk@...eshk-thinkpad) (aarch64-linux-gnu-gcc (Ubuntu
13.3.0-6ubuntu2~24.04) 13.3.0, GNU ld (GNU Binutils for Ubuntu) 2.42)
#2 SMP PREEMPT Wed May  7 18:13:46 IST 2025

[    7.753403]     # rust_doctest_kernel_clk_rs_0.location:
rust/kernel/clk.rs:24
[    7.761907]     ok 33 rust_doctest_kernel_clk_rs_0
[    7.767603]     # rust_doctest_kernel_clk_rs_1.location:
rust/kernel/clk.rs:264
[    7.775203]     ok 34 rust_doctest_kernel_clk_rs_1
[    7.779262]     # rust_doctest_kernel_clk_rs_2.location:
rust/kernel/clk.rs:98
[    7.787712]     ok 35 rust_doctest_kernel_clk_rs_2
[    7.792734]     # rust_doctest_kernel_cpufreq_rs_0.location:
rust/kernel/cpufreq.rs:205
[    7.800677]     ok 36 rust_doctest_kernel_cpufreq_rs_0
[    7.806046]     # rust_doctest_kernel_cpufreq_rs_1.location:
rust/kernel/cpufreq.rs:320
[    7.815118]     ok 37 rust_doctest_kernel_cpufreq_rs_1
[    7.820364]     # rust_doctest_kernel_cpufreq_rs_2.location:
rust/kernel/cpufreq.rs:397
[    7.828260]     ok 38 rust_doctest_kernel_cpufreq_rs_2
[    7.833076]     # rust_doctest_kernel_cpufreq_rs_3.location:
rust/kernel/cpufreq.rs:834
[    7.840629]     ok 39 rust_doctest_kernel_cpufreq_rs_3
[    7.844859]     # rust_doctest_kernel_cpumask_rs_0.location:
rust/kernel/cpumask.rs:180
[    7.854280]     ok 40 rust_doctest_kernel_cpumask_rs_0
[    7.859624]     # rust_doctest_kernel_cpumask_rs_1.location:
rust/kernel/cpumask.rs:36
[    7.868109]     ok 41 rust_doctest_kernel_cpumask_rs_1

Attached my .config too.

> Viresh: could you please make sure `defconfig`s (and `allmodconfig`s)
> are clean? (including with debug assertions and doctests enabled).

Anything apart from this ?

CONFIG_RUST_KERNEL_DOCTESTS=y

Sorry for the trouble, I thought this is all covered already
(apart from x86 failure).

--
Viresh

[1] https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git
cpufreq/arm/linux-next

Download attachment ".config" of type "application/octet-stream" (311948 bytes)