linux-kernel - Re: [PATCH v5 2/3] arm64: dts: ti: k3-am62l: add initial infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250508123359.k72q4u45wzms7uaw@handpick>
Date: Thu, 8 May 2025 07:33:59 -0500
From: Nishanth Menon <nm@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Bryan Brattlof <bb@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Tero
 Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/3] arm64: dts: ti: k3-am62l: add initial
 infrastructure

On 08:56-20250508, Krzysztof Kozlowski wrote:
> On 08/05/2025 08:52, Krzysztof Kozlowski wrote:
> > On Wed, May 07, 2025 at 10:09:20PM GMT, Bryan Brattlof wrote:
> >> +
> >> +	uart6: serial@...0000 {
> >> +		compatible = "ti,am64-uart", "ti,am654-uart";
> >> +		reg = <0x00 0x02860000 0x00 0x100>;
> >> +		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> >> +		power-domains = <&scmi_pds 82>;
> >> +		clocks = <&scmi_clk 322>;
> >> +		clock-names = "fclk";
> >> +		status = "disabled";
> >> +	};
> >> +
> >> +	conf: syscon@...0000 {
> >> +		compatible = "syscon", "simple-mfd";
> > 
> > Not much improved here. You cannot have such compatibles alone and the
> > bindings test this.
> > 
> > Are you sure you tested this?
> I now tested it and I am 100% sure you did not.
> 
> Use tools and computers instead of humans for finding trivial issues.
> This is not really acceptable.

Agree.

Bryan,
In addition to bisect fails in this series, I see the following
dtbs_check errors:

arch/arm64/boot/dts/ti/k3-am62l3-evm.dtb: serial@0: clock-names:0: 'fclk' was expected
arch/arm64/boot/dts/ti/k3-am62l3-evm.dtb: spi@...0000: '#address-cells' is a dependency of '#size-cells'
arch/arm64/boot/dts/ti/k3-am62l3-evm.dtb: syscon@...00000: compatible: ['syscon', 'simple-mfd'] is too short
arch/arm64/boot/dts/ti/k3-am62l3-evm.dtb: syscon@...0000: 'reg' is a required property

I suggest doing a revisit of this for the next window.

PS: https://github.com/nmenon/kernel_patch_verify is a tool I use and
maintain which might help alleviate some of the easy checklist items -
but this is probably not an authoritative tool and making sure, but if
it helps you, please do use it - it is containerized for easy env setup
(you could run kpv -V -C -L -3 for example on this series and get this:
https://gist.github.com/nmenon/83f7e6924539d1c7e2eb6c5a4ee82706 )

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D