linux-kernel - Re: [PATCH v6 6/6] arm64: dts: qcom: x1e78100-t14s: Enable audio headset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aByn1mnsClCquBSh@hovoldconsulting.com>
Date: Thu, 8 May 2025 14:47:18 +0200
From: Johan Hovold <johan@...nel.org>
To: Bjorn Andersson <andersson@...nel.org>
Cc: peda@...ntia.se, broonie@...nel.org, andersson@...nel.org,
	krzk+dt@...nel.org, ivprusov@...utedevices.com,
	luca.ceresoli@...tlin.com, zhoubinbin@...ngson.cn,
	paulha@...nsource.cirrus.com, lgirdwood@...il.com, robh@...nel.org,
	conor+dt@...nel.org, konradybcio@...nel.org, perex@...ex.cz,
	tiwai@...e.com, dmitry.baryshkov@....qualcomm.com,
	linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	johan+linaro@...nel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Christopher Obbard <christopher.obbard@...aro.org>,
	srinivas.kandagatla@...aro.org
Subject: Re: [PATCH v6 6/6] arm64: dts: qcom: x1e78100-t14s: Enable audio
 headset support

Hi Bjorn,

On Wed, Apr 02, 2025 at 10:08:24AM +0200, Johan Hovold wrote:
> On Thu, Mar 27, 2025 at 10:06:33AM +0000, Srinivas Kandagatla wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> > 
> > On Lenovo ThinkPad T14s, the headset is connected via a HiFi mux to
> > support CTIA and OMTP headsets. This switch is used to minimise pop and
> > click during headset type switching.
> > 
> > Enable the mux controls required to power this switch along with wiring up
> > gpio that control the headset switching.
> > 
> > Without this, headset audio will be very noisy and might see headset
> > detection errors.
> > 
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Tested-by: Christopher Obbard <christopher.obbard@...aro.org>
> 
> Looks good and both playback and recording works fine:
> 
> Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
> Tested-by: Johan Hovold <johan+linaro@...nel.org>

Assuming the mux change will make it into 6.16 now, can you pick this
one up as well?

Johan