linux-kernel - Re: [PATCH 1/2] dt-bindings: Document Tegra264 ADMA support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a6e46ea-bc8f-4e4e-ba74-e01c977f25d5@kernel.org>
Date: Thu, 8 May 2025 14:47:11 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Sheetal ." <sheetal@...dia.com>, vkoul@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org
Cc: dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
 thierry.reding@...il.com, jonathanh@...dia.com, ldewangan@...dia.com
Subject: Re: [PATCH 1/2] dt-bindings: Document Tegra264 ADMA support

On 08/05/2025 14:35, Sheetal . wrote:
> From: Sheetal <sheetal@...dia.com>
> 
> Add Tegra264 ADMA support to the device tree bindings documentation.
> The Tegra264 ADMA hardware supports 64 DMA channels and requires
> specific register configurations.
> 
> The binding maintains compatibility with existing Tegra platforms
> while adding support for Tegra264-specific features.

This is confusing sentence, because you did not make anything compatible
there. Drop it.

> 
> Signed-off-by: Sheetal <sheetal@...dia.com>
> ---
>  Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml
> index d3f8c269916c..d204be46b90e 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml
> @@ -19,6 +19,7 @@ properties:
>        - enum:
>            - nvidia,tegra210-adma
>            - nvidia,tegra186-adma
> +          - nvidia,tegra264-adma


This is incomplete, missing constraints. Read *ENTIRE* binding, not top
25 lines only.

Best regards,
Krzysztof