linux-kernel - Re: [PATCH net-next] vhost/net: align variable names with XDP terminology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <681cb4b95dde7_2583cf294d@willemb.c.googlers.com.notmuch>
Date: Thu, 08 May 2025 09:42:17 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jon Kohler <jon@...anix.com>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: "Michael S. Tsirkin" <mst@...hat.com>, 
 Jason Wang <jasowang@...hat.com>, 
 Eugenio Pérez <eperezma@...hat.com>, 
 Alexei Starovoitov <ast@...nel.org>, 
 Daniel Borkmann <daniel@...earbox.net>, 
 "David S. Miller" <davem@...emloft.net>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Jesper Dangaard Brouer <hawk@...nel.org>, 
 John Fastabend <john.fastabend@...il.com>, 
 "kvm@...r.kernel.org" <kvm@...r.kernel.org>, 
 "virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>, 
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
 "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: Re: [PATCH net-next] vhost/net: align variable names with XDP
 terminology

Jon Kohler wrote:
> 
> 
> > On May 7, 2025, at 1:23 PM, Willem de Bruijn <willemdebruijn.kernel@...il.com> wrote:
> > 
> > !-------------------------------------------------------------------|
> >  CAUTION: External Email
> > 
> > |-------------------------------------------------------------------!
> > 

Minor: can you fix email to avoid the above?

> > Jon Kohler wrote:
> >> Refactor variable names in vhost_net_build_xdp to align with XDP
> >> terminology, enhancing code clarity and consistency. Additionally,
> >> reorder variables to follow a reverse Christmas tree structure,
> >> improving code organization and readability.
> >> 
> >> This change introduces no functional modifications.
> >> 
> >> Signed-off-by: Jon Kohler <jon@...anix.com>
> > 
> > We generally don't do pure refactoring patches.
> > 
> > They add churn to code history for little gain (and some
> > overhead and risk).
> > 
> 
> Ok, I’ll club this together with the larger change I’m working on
> for multi-buffer support in vhost/net, ill send that as a series
> when it is ready for eyes

I forgot to add that it makes stable fixes harder to apply across
LTS, distro and other derived kernels.

So resist the urge the just make stylistic changes. Functional
improvements warrants the risk, churn and extra work.