[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6e861958-da74-4761-abb6-c7f3b56f7784@arm.com>
Date: Thu, 8 May 2025 14:42:10 +0100
From: Ada Couprie Diaz <ada.coupriediaz@....com>
To: Anshuman Khandual <anshuman.khandual@....com>,
linux-arm-kernel@...ts.infradead.org
Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
Mark Rutland <mark.rutland@....com>, linux-kernel@...r.kernel.org,
Ada Couprie Diaz <ada.coupriediaz@....com>
Subject: Re: [PATCH V2] arm64/debug: Drop redundant DBG_MDSCR_* macros
Hi Anshuman,
On 08/05/2025 05:47, Anshuman Khandual wrote:
> MDSCR_EL1 has already been defined in tools sysreg format and hence can be
> used in all debug monitor related call paths. Subsequently all DBG_MDSCR_*
> macros become redundant and hence can be dropped off completely. While here
> convert all variables handling MDSCR_EL1 register as u64 which reflects its
> true width as well.
>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
> ---
> This patch applies on v6.15-rc5
>
> Changes in V2:
>
> - Changed reg, val width to u64 in cortex_a76_erratum_1463225_svc_handler() per Ada
> - Changed mdscr register width to uint64_t in enable_monitor_debug_exceptions() and
> install_ss() per Ada
Thanks for the changes, the patch looks good to me now !
Reviewed-by: Ada Couprie Diaz <ada.coupriediaz@....com>
Powered by blists - more mailing lists