linux-kernel - Re: [PATCH V2] arm64/debug: Drop redundant DBG_MDSCR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250509161752.GC5984@willie-the-truck>
Date: Fri, 9 May 2025 17:17:53 +0100
From: Will Deacon <will@...nel.org>
To: Anshuman Khandual <anshuman.khandual@....com>
Cc: linux-arm-kernel@...ts.infradead.org, ada.coupriediaz@....com,
	Catalin Marinas <catalin.marinas@....com>,
	Mark Rutland <mark.rutland@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] arm64/debug: Drop redundant DBG_MDSCR_* macros

On Thu, May 08, 2025 at 10:17:52AM +0530, Anshuman Khandual wrote:
> MDSCR_EL1 has already been defined in tools sysreg format and hence can be
> used in all debug monitor related call paths. Subsequently all DBG_MDSCR_*
> macros become redundant and hence can be dropped off completely. While here
> convert all variables handling MDSCR_EL1 register as u64 which reflects its
> true width as well.
> 
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
> ---
> This patch applies on v6.15-rc5
> 
> Changes in V2:
> 
> - Changed reg, val width to u64 in cortex_a76_erratum_1463225_svc_handler() per Ada
> - Changed mdscr register width to uint64_t in enable_monitor_debug_exceptions() and
>   install_ss() per Ada
>     
> Changes in V1:
> 
> https://lore.kernel.org/all/20250417105253.3188976-1-anshuman.khandual@arm.com/
> 
>  arch/arm64/include/asm/assembler.h            |  4 ++--
>  arch/arm64/include/asm/debug-monitors.h       |  6 -----
>  arch/arm64/kernel/debug-monitors.c            | 22 +++++++++----------
>  arch/arm64/kernel/entry-common.c              |  4 ++--
>  .../selftests/kvm/arm64/debug-exceptions.c    |  4 ++--
>  5 files changed, 17 insertions(+), 23 deletions(-)

Can you post the selftest change as a separate patch, please?

Will