linux-kernel - Re: [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aB6oxlR6DINIvdLM@gondor.apana.org.au>
Date: Sat, 10 May 2025 09:15:50 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Corentin Labbe <clabbe.montjoie@...il.com>
Cc: Klaus Kudielka <klaus.kudielka@...il.com>, regressions@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	Boris Brezillon <bbrezillon@...nel.org>,
	EBALARD Arnaud <Arnaud.Ebalard@....gouv.fr>,
	Romain Perier <romain.perier@...il.com>
Subject: Re: [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests

On Fri, May 09, 2025 at 01:01:21PM +0200, Corentin Labbe wrote:
>
> Got http://kernel.montjoie.ovh/478064.log

OK it seems to go further, but that might just because the first
few tests get done with no concurrency.

I see some bugs in the driver with regards to zero-length updates,
but I'm at a loss as to why that would only make a difference when
run concurrently.

Please add this patch on top of the previous patch.  It disables
chaining altogether between requests.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/drivers/crypto/marvell/cesa/tdma.c b/drivers/crypto/marvell/cesa/tdma.c
index 9b5fd957dde2..f4fe2a881f1e 100644
--- a/drivers/crypto/marvell/cesa/tdma.c
+++ b/drivers/crypto/marvell/cesa/tdma.c
@@ -123,7 +123,7 @@ void mv_cesa_tdma_chain(struct mv_cesa_engine *engine,
 	 * Break the DMA chain if the CESA_TDMA_BREAK_CHAIN is set on
 	 * the last element of the current chain.
 	 */
-	if (last->flags & CESA_TDMA_BREAK_CHAIN) {
+	if (1 || (last->flags & CESA_TDMA_BREAK_CHAIN)) {
 		engine->chain_sw.first = NULL;
 		engine->chain_sw.last = NULL;
 	}