linux-kernel - Re: [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aB6t9lfMCSuYVxwv@gondor.apana.org.au>
Date: Sat, 10 May 2025 09:37:58 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Corentin Labbe <clabbe.montjoie@...il.com>
Cc: Klaus Kudielka <klaus.kudielka@...il.com>, regressions@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	Boris Brezillon <bbrezillon@...nel.org>,
	EBALARD Arnaud <Arnaud.Ebalard@....gouv.fr>,
	Romain Perier <romain.perier@...il.com>
Subject: Re: [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests

On Sat, May 10, 2025 at 09:15:50AM +0800, Herbert Xu wrote:
> 
> I see some bugs in the driver with regards to zero-length updates,
> but I'm at a loss as to why that would only make a difference when
> run concurrently.

In particular, when testmgr does an update+final, it will give a
non-NULL SG list to the final call.

The buggy code in marvell/cesa will then read that non-NULL SG list
during the final call and overwrite the cached bytes with it.
However, I still can't see why that would make a difference because
it should contain the same data.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt