linux-kernel - mtd: rawnand: brcmnand: exec_op patch broke

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKR-sGezB_SEb7UfPV6o6T2yibkAzNSqK9Hry1kNM46BMsH2_g@mail.gmail.com>
Date: Sun, 11 May 2025 11:42:27 +0200
From: Álvaro Fernández Rojas <noltari@...il.com>
To: dregan@...adcom.com, Miquel Raynal <miquel.raynal@...tlin.com>, 
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>, 
	MTD Maling List <linux-mtd@...ts.infradead.org>, Florian Fainelli <f.fainelli@...il.com>, 
	Rafał Miłecki <rafal@...ecki.pl>, 
	joel.peshkin@...adcom.com, Brian Norris <computersforpeace@...il.com>, 
	dan.beygelman@...adcom.com, William Zhang <william.zhang@...adcom.com>, 
	frieder.schrempf@...tron.de, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Vignesh R <vigneshr@...com>, 
	Richard Weinberger <richard@....at>, bbrezillon@...nel.org, Kamal Dasu <kdasu.kdev@...il.com>, 
	liao jaime <jaimeliao.tw@...il.com>, kilobyte@...band.pl, 
	Jonas Gorski <jonas.gorski@...il.com>, dgcbueu <dgcbueu@...il.com>
Subject: mtd: rawnand: brcmnand: exec_op patch broke < v5.0 controllers

Hi David,

I've just realized that your exec_op implementation patch broke
support of v2.1, v2.2 and v4.0 controllers.
https://github.com/torvalds/linux/commit/3c8260ce76634291aed877032a41e373884d69e4
https://patchwork.ozlabs.org/project/linux-mtd/patch/20231125012438.15191-4-dregan@broadcom.com/
I know it's an old patch from 6.8 but I just discovered this while
trying to add 6.12 support for bmips on OpenWrt (from 6.6):
https://github.com/openwrt/openwrt/pull/18746

The issue is that low level ops always return 0 on v4.0 controllers
and v2.1/v2.2 controllers don't even have the low level registers
defined:
https://github.com/torvalds/linux/blob/3ce9925823c7d6bb0e6eb951bf2db0e9e182582d/drivers/mtd/nand/raw/brcmnand/brcmnand.c#L357
https://github.com/torvalds/linux/blob/3ce9925823c7d6bb0e6eb951bf2db0e9e182582d/drivers/mtd/nand/raw/brcmnand/brcmnand.c#L371

I guess that restoring the legacy functions isn't going to happen, but
is it possible to restore < v5.0 compatibility on the new exec_op
implementation?

Best regards,
Álvaro.