linux-kernel - Re: [PATCH] PM / devfreq: Fix a typo in trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGTfZH2wmoxzM_63baBON+adntMZhR_i4d1DPwBpg7=p+6_Dzg@mail.gmail.com>
Date: Sun, 11 May 2025 21:43:32 +0900
From: Chanwoo Choi <chanwoo@...nel.org>
To: pleasurefish@....com
Cc: myungjoo.ham@...sung.com, kyungmin.park@...sung.com, cw00.choi@...sung.com, 
	ansuelsmth@...il.com, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / devfreq: Fix a typo in trans_stat

Hi,

Looks good to me for this patch.

But, you need to use your name instead of 'pls' on following
Signed-off-by and author information.
I would like you to update your name on this patch and then better to
add the some patch description

- Signed-off-by: pls <pleasurefish@....com>

Thanks,

On Sat, Feb 8, 2025 at 11:29 AM <pleasurefish@....com> wrote:
>
> From: pls <pleasurefish@....com>
>
> Fixes: 4920ee6dcfaf ("PM / devfreq: Convert to use sysfs_emit_at() API")
> Signed-off-by: pls <pleasurefish@....com>
> ---
>  drivers/devfreq/devfreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 98657d3b9435..a0223c60f4eb 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -1743,7 +1743,7 @@ static ssize_t trans_stat_show(struct device *dev,
>         for (i = 0; i < max_state; i++) {
>                 if (len >= PAGE_SIZE - 1)
>                         break;
> -               if (df->freq_table[2] == df->previous_freq)
> +               if (df->freq_table[i] == df->previous_freq)
>                         len += sysfs_emit_at(buf, len, "*");
>                 else
>                         len += sysfs_emit_at(buf, len, " ");
> --
> 2.39.5
>
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics