linux-kernel - Re: [PATCH v3 1/3] driver/base: Optimize memory block registration to reduce boot time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e20d51e-ab22-4aeb-860f-9cdff0fb47c4@linux.ibm.com>
Date: Sun, 11 May 2025 18:03:19 +0530
From: Donet Tom <donettom@...ux.ibm.com>
To: Mike Rapoport <rppt@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
        Oscar Salvador <osalvador@...e.de>, Zi Yan <ziy@...dia.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>, rafael@...nel.org,
        Danilo Krummrich <dakr@...nel.org>,
        Ritesh Harjani <ritesh.list@...il.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Yury Norov <yury.norov@...il.com>, Dave Jiang <dave.jiang@...el.com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] driver/base: Optimize memory block registration to
 reduce boot time


On 5/11/25 11:09 AM, Mike Rapoport wrote:
> Hi Donet,
>
> On Fri, May 09, 2025 at 09:10:34PM +0530, Donet Tom wrote:
>>>> Then we can drop the call to register_memory_blocks_under_node() from
>>>> register_one_node() and add creation of memory blocks to
>>>> node_dev_init(),
>>>> i.e.
>>>>
>>>> node_dev_init()
>>>>     for_each_node(nid)
>>>>       __register_one_node(nid)
>>>>         for_each_mem_region()
>>>>           /* create memory block if node matches */
>>> Yes exactly, that makes sense.
>> Hi Andrew and Mike
>>
>> Based on the discussion so far, it is clear that the patch will work in all cases,
>> including when CONFIG_ARCH_KEEP_MEMBLOCK  is disabled. Just checking —
>> would you prefer to take this version, or should I send a v4?
> During the discussion we concluded that the right thing to do seems to drop
> the call to register_memory_blocks_under_node() from register_one_node()
> and make node_dev_init() call __register_one_node() and then create memory
> blocks for each memblock region.
>
> Can you please make v4 along those lines?
>
Sure, I will do that.

Thank you.


>   
>> Thanks
>> Donet