linux-kernel - Re: [patch V2 26/45] genirq/chip: Rework irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250511172911.1008109-1-ojeda@kernel.org>
Date: Sun, 11 May 2025 19:29:11 +0200
From: Miguel Ojeda <ojeda@...nel.org>
To: nathan@...nel.org
Cc: jirislaby@...nel.org,
	linux-kernel@...r.kernel.org,
	peterz@...radead.org,
	tglx@...utronix.de
Subject: Re: [patch V2 26/45] genirq/chip: Rework irq_set_handler() variants

On Fri, 09 May 2025 14:22:11 +0100 Nathan Chancellor <nathan@...nel.org> wrote:
>
> I am investigating some cases where
>
> WARN(!irqs_disabled(), "Interrupts were enabled early\n");
>
> in start_kernel() in init/main.c is triggered in certain builds with
> clang after patch 23 of this series (very bizarre since the conversion
> seems to be correct) and I happened to notice that this conversion seems
> to be incorrect? Should this be scoped_irqdesc_get_and_buslock() like
> below?

Yeah, I am also seeing this in next-20250509 in a LLVM=1 arm64 defconfig + Rust
build under QEMU.

Cheers,
Miguel

[    0.007387] ------------[ cut here ]------------
[    0.007414] Interrupts were enabled early
[    0.007833] WARNING: CPU: 0 PID: 0 at init/main.c:1023 start_kernel+0x31c/0x394
[    0.008001] Modules linked in:
[    0.008340] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.15.0-rc5-next-20250509 #1 PREEMPT
[    0.008458] Hardware name: linux,dummy-virt (DT)
[    0.008610] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[    0.008641] pc : start_kernel+0x31c/0x394
[    0.008657] lr : start_kernel+0x31c/0x394
[    0.008670] sp : ffffdcd810333e80
[    0.008688] x29: ffffdcd810333e90 x28: 0000000000000000 x27: 0000000000000000
[    0.008748] x26: 0000000000000000 x25: 0000000000000000 x24: 0000000000000000
[    0.008762] x23: 0000000000000000 x22: 0000000000000000 x21: 0000000044200000
[    0.008775] x20: ffffdcd81033a000 x19: ffffdcd810345940 x18: 00000000000000b0
[    0.008789] x17: 0000000000000000 x16: 0000000000000008 x15: 0000000000000004
[    0.008802] x14: ffffdcd81036e830 x13: 0000000000000003 x12: 0000000000000003
[    0.008815] x11: 00000000ffffefff x10: 0000000000000000 x9 : 77ed5dd15956fc00
[    0.008849] x8 : 77ed5dd15956fc00 x7 : 2065726577207374 x6 : 7075727265746e49
[    0.008862] x5 : ffffdcd810886ef6 x4 : ffffdcd80fe025f2 x3 : 0000000000000000
[    0.008875] x2 : 0000000000000000 x1 : ffffdcd810333b80 x0 : 000000000000001d
[    0.008985] Call trace:
[    0.009142]  start_kernel+0x31c/0x394 (P)
[    0.009320]  __primary_switched+0x88/0x90
[    0.009501] ---[ end trace 0000000000000000 ]---

[    0.007587] ------------[ cut here ]------------
[    0.007623] Interrupts were enabled early
[    0.008277] WARNING: CPU: 0 PID: 0 at init/main.c:1023 start_kernel+0x31c/0x394
[    0.008526] Modules linked in:
[    0.009030] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.15.0-rc5-next-20250509 #1 PREEMPT
[    0.009228] Hardware name: linux,dummy-virt (DT)
[    0.009459] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[    0.009507] pc : start_kernel+0x31c/0x394
[    0.009531] lr : start_kernel+0x31c/0x394
[    0.009554] sp : ffffd5bfd7933e80
[    0.009585] x29: ffffd5bfd7933e90 x28: 0000000000000000 x27: 0000000000000000
[    0.009672] x26: 0000000000000000 x25: 0000000000000000 x24: 0000000000000000
[    0.009687] x23: 0000000000000000 x22: 0000000000000000 x21: 0000000044200000
[    0.009701] x20: ffffd5bfd793a000 x19: ffffd5bfd7945940 x18: 00000000000000b0
[    0.009715] x17: 0000000000000000 x16: 0000000000000008 x15: 0000000000000004
[    0.009729] x14: ffffd5bfd796e830 x13: 0000000000000003 x12: 0000000000000003
[    0.009743] x11: 00000000ffffefff x10: 0000000000000000 x9 : 2d9976f44ddcd000
[    0.009778] x8 : 2d9976f44ddcd000 x7 : 2065726577207374 x6 : 7075727265746e49
[    0.009792] x5 : ffffd5bfd7e86ef6 x4 : ffffd5bfd74025f2 x3 : 0000000000000000
[    0.009806] x2 : 0000000000000000 x1 : ffffd5bfd7933b80 x0 : 000000000000001d
[    0.009914] Call trace:
[    0.010060]  start_kernel+0x31c/0x394 (P)
[    0.010250]  __primary_switched+0x88/0x90
[    0.010458] ---[ end trace 0000000000000000 ]---