linux-kernel - Re: [PATCH v2] net: dsa: qca8k: fix led devicename when using external mdio bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DS7PR19MB8883DB4229F7505CA877A3EC9D97A@DS7PR19MB8883.namprd19.prod.outlook.com>
Date: Mon, 12 May 2025 14:40:10 +0400
From: George Moussalem <george.moussalem@...look.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: dsa: qca8k: fix led devicename when using
 external mdio bus

Hi Andrew,

On 4/26/25 01:15, Andrew Lunn wrote:
> On Fri, Apr 25, 2025 at 01:19:28PM +0400, George Moussalem via B4 Relay wrote:
>> From: George Moussalem <george.moussalem@...look.com>
>>
>> The qca8k dsa switch can use either an external or internal mdio bus.
>> This depends on whether the mdio node is defined under the switch node
>> itself and, as such, the internal_mdio_mask is populated with its
>> internal phys. Upon registering the internal mdio bus, the slave_mii_bus
>> of the dsa switch is assigned to this bus. When an external mdio bus is
>> used, it is left unassigned, though its id is used to create the device
>> names of the leds.
>> This leads to the leds being named '(efault):00:green:lan' and so on as
>> the slave_mii_bus is null. So let's fix this by adding a null check and
>> use the devicename of the external bus instead when an external bus is
>> configured.
>>
>> Signed-off-by: George Moussalem <george.moussalem@...look.com>
> 
> Before merging this, i think we need to finish the discussion here:
> 
> https://patchwork.kernel.org/project/netdevbpf/patch/20250425151309.30493-1-kabel@kernel.org/
> 
> It might be the whole internal/external bus is going away...

I've been following that discussion but haven't seen any update since 
April 25. There's also no 'guarantee' that the submitter will actually 
follow up based on the feedback provided. Either way, could this patch 
be merged even if the decision is to remove the internal bus from the 
driver because this patch accommodates for both scenarios by adding bus 
id of the external mdio bus which would be needed anyways. Or am I 
missing something?

> 
>      Andrew
> 
> ---
> pw-bot: cr

Thanks,
George