linux-kernel - Re: [PATCH] ALSA: msnd: Remove midi code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aCHZE7G2kTeGrDlN@gallifrey>
Date: Mon, 12 May 2025 11:18:43 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Takashi Iwai <tiwai@...e.de>
Cc: perex@...ex.cz, tiwai@...e.com, krzysztof.h1@...pl,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: msnd: Remove midi code

* Takashi Iwai (tiwai@...e.de) wrote:
> On Sun, 11 May 2025 19:29:57 +0200,
> linux@...blig.org wrote:
> > 
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > 
> > Nothing calls snd_msndmidi_new()
> >   thus nothing sets chip->msndmidi_mpu
> >     The call to snd_msndmidi_input_read is gated on that being set,
> >     so snd_msndmidi_input_read() won't be called either.
> > 
> > This is probably a missing call to snd_msndmidi_new(), but since
> > this is ancient code, it's probably best to remove it (especially
> > since I don't have the hardware to test it).
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> 
> Applied now.  Thanks.

Thanks!

Dave

> 
> Takashi
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/