linux-kernel - Re: [PATCH v5 05/10] mfd: Add Apple Silicon System Management Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <50f35475-958e-481a-83f8-f19fc2259191@app.fastmail.com>
Date: Mon, 12 May 2025 13:18:29 +0200
From: "Sven Peter" <sven@...npeter.dev>
To: "Alyssa Rosenzweig" <alyssa@...enzweig.io>
Cc: "Janne Grunau" <j@...nau.net>, "Neal Gompa" <neal@...pa.dev>,
 "Hector Martin" <marcan@...can.st>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Bartosz Golaszewski" <brgl@...ev.pl>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>, "Sebastian Reichel" <sre@...nel.org>,
 "Lee Jones" <lee@...nel.org>, "Marc Zyngier" <maz@...nel.org>,
 "Russell King" <rmk+kernel@...linux.org.uk>, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org,
 "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v5 05/10] mfd: Add Apple Silicon System Management Controller

Hi,


On Sun, May 11, 2025, at 18:51, Alyssa Rosenzweig wrote:
>> +struct apple_smc_key_info {
>> +	u8 size;
>> +	u32 type_code;
>> +	u8 flags;
>> +};
>
> This still has the padding problem from v4. With that fixed,

I somehow managed to drop two !fixup commits before sending this out :-(
One of them was moving type_code to the beginning and the other some cosmetic
changes (mainly starting descriptions with uppercase letters) to macsmc.h.
Will be fixed for the next version for real this time.


>
> Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io>

Thanks,


Sven