linux-kernel - [PATCH] btrfs: correct the assert for subpage case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250512132850.2973032-1-neelx@suse.com>
Date: Mon, 12 May 2025 15:28:50 +0200
From: Daniel Vacek <neelx@...e.com>
To: Chris Mason <clm@...com>,
	Josef Bacik <josef@...icpanda.com>,
	David Sterba <dsterba@...e.com>
Cc: Daniel Vacek <neelx@...e.com>,
	linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] btrfs: correct the assert for subpage case

The assert is only true in !subpage case. We can either fix it this way
or completely remove it.

This fixes and should be folded into:
	btrfs: fix broken drop_caches on extent buffer folios

Signed-off-by: Daniel Vacek <neelx@...e.com>
---
 fs/btrfs/extent_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 80a8563a25add..3b3f73894ffe2 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -3411,7 +3411,7 @@ struct extent_buffer *alloc_extent_buffer(struct btrfs_fs_info *fs_info,
 			continue;
 		}
 
-		ASSERT(!folio_test_private(folio));
+		ASSERT(!btrfs_meta_is_subpage(fs_info) && !folio_test_private(folio));
 		folio_put(folio);
 		eb->folios[i] = NULL;
 	}
-- 
2.47.2