linux-kernel - Re: [RFC 01/19] netmem: rename struct net_iov to struct netmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250512132939.GF45370@system.software.com>
Date: Mon, 12 May 2025 22:29:39 +0900
From: Byungchul Park <byungchul@...com>
To: Pavel Begunkov <asml.silence@...il.com>
Cc: willy@...radead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	kernel_team@...ynix.com, kuba@...nel.org, almasrymina@...gle.com,
	ilias.apalodimas@...aro.org, harry.yoo@...cle.com, hawk@...nel.org,
	akpm@...ux-foundation.org, ast@...nel.org, daniel@...earbox.net,
	davem@...emloft.net, john.fastabend@...il.com,
	andrew+netdev@...n.ch, edumazet@...gle.com, pabeni@...hat.com,
	vishal.moola@...il.com
Subject: Re: [RFC 01/19] netmem: rename struct net_iov to struct netmem_desc

On Mon, May 12, 2025 at 02:11:13PM +0100, Pavel Begunkov wrote:
> On 5/9/25 12:51, Byungchul Park wrote:
> > To simplify struct page, the page pool members of struct page should be
> > moved to other, allowing these members to be removed from struct page.
> > 
> > Reuse struct net_iov for also system memory, that already mirrored the
> > page pool members.
> > 
> > Signed-off-by: Byungchul Park <byungchul@...com>
> > ---
> >   include/linux/skbuff.h                  |  4 +--
> >   include/net/netmem.h                    | 20 ++++++------
> >   include/net/page_pool/memory_provider.h |  6 ++--
> >   io_uring/zcrx.c                         | 42 ++++++++++++-------------
> 
> You're unnecessarily complicating it for yourself. It'll certainly
> conflict with changes in the io_uring tree, and hence it can't
> be taken normally through the net tree.
> 
> Why are you renaming it in the first place? If there are good

It's because the struct should be used for not only io vetor things but
also system memory.  Current network code uses struct page as system
memory descriptor but struct page fields for page pool will be gone.

So I had to reuse struct net_iov and I thought renaming it made more
sense.  It'd be welcome if you have better idea.

	Byungchul

> reasons, maybe you can try adding a temporary alias of the struct
> and patch io_uring later separately.
> 
> -- 
> Pavel Begunkov
>