linux-kernel - Re: [net-next PATCH v4 09/11] net: macb: Move most of mac_config to mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <964d667a-c17e-47ff-b7d8-fb5b5a2f1eef@linux.dev>
Date: Tue, 13 May 2025 12:40:09 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: "Karumanchi, Vineeth" <vineeth.karumanchi@....com>,
 netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>
Cc: upstream@...oha.com, Simon Horman <horms@...nel.org>,
 Heiner Kallweit <hkallweit1@...il.com>,
 Kory Maincent <kory.maincent@...tlin.com>, linux-kernel@...r.kernel.org,
 Christian Marangi <ansuelsmth@...il.com>,
 Claudiu Beznea <claudiu.beznea@...rochip.com>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>
Subject: Re: [net-next PATCH v4 09/11] net: macb: Move most of mac_config to
 mac_prepare

On 5/13/25 11:29, Karumanchi, Vineeth wrote:
> Hi Sean,
> 
> Sorry for the delayed response.
> 
> We are working on MACB with two internal PCS's (10G-BASER, 1000-BASEX) supporting 1G, 2.5G, 5G, and 10G with AN disabled.
> 
> I have sent an initial RFC : https://lore.kernel.org/netdev/20241009053946.3198805-1-vineeth.karumanchi@amd.com/
> 
> Currently, we are working on integrating the MAC in fixed-link and phy-mode.

I had a look your series and based on the feedback you got I think this
patch will help you ensure the PCS changes stay separate from the MAC
stuff. I found it confusing on first read that you were configuring the
"1G" PCS from the USX PCS callback. I think you are using 1G/2G speeds
with the "1G" PCS and 5G/10G speeds with the USX PCS?

Do you know if there is any public documentation for 10G support
(even on non-versal SoCs)? That will make it easier to review your
patch.

--Sean