linux-kernel - Re: [PATCH] x86/its: Fix build errors when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49808711-a5af-488a-9fd1-246c4da10100@intel.com>
Date: Tue, 13 May 2025 13:32:07 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Eric Biggers <ebiggers@...nel.org>, x86@...nel.org,
 Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org, Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
Subject: Re: [PATCH] x86/its: Fix build errors when CONFIG_MODULES=n

On 5/13/25 11:54, Dave Hansen wrote:
> On 5/12/25 19:58, Eric Biggers wrote:
>> From: Eric Biggers <ebiggers@...gle.com>
>>
>> Fix several build errors when CONFIG_MODULES=n, including the following:
>>
>> ../arch/x86/kernel/alternative.c:195:25: error: incomplete definition of type 'struct module'
>>   195 |         for (int i = 0; i < mod->its_num_pages; i++) {

Linus, could you pick this one up directly, please? The thread has acks
from a few folks already.

The normal x86/urgent branch doesn't have this bug yet and I don't want
to merge the existing pile of fixes with your tree at a completely
random point.

Oh, and you called it ... "done without public testing" strikes again.