linux-kernel - Re: [PATCH net v2] net: dsa: microchip: linearize skb for tail-tagging switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250513163744.20299747@kernel.org>
Date: Tue, 13 May 2025 16:37:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jakob Unterwurzacher <jakobunt@...il.com>
Cc: Woojung Huh <woojung.huh@...rochip.com>, UNGLinuxDriver@...rochip.com,
 Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Marek Vasut
 <marex@...x.de>, Tristram Ha <Tristram.Ha@...rochip.com>, Florian Fainelli
 <f.fainelli@...il.com>, jakob.unterwurzacher@...rry.de,
 stable@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: dsa: microchip: linearize skb for
 tail-tagging switches

On Mon, 12 May 2025 16:44:18 +0200 Jakob Unterwurzacher wrote:
>  static struct sk_buff *ksz9477_rcv(struct sk_buff *skb, struct net_device *dev)
>  {
> +	u8 *tag;
> +
> +	if (skb_linearize(skb))
> +		return NULL;
> +
>  	/* Tag decoding */
> -	u8 *tag = skb_tail_pointer(skb) - KSZ_EGRESS_TAG_LEN;
> +	tag = skb_tail_pointer(skb) - KSZ_EGRESS_TAG_LEN;
>  	unsigned int port = tag[0] & KSZ9477_TAIL_TAG_EG_PORT_M;
>  	unsigned int len = KSZ_EGRESS_TAG_LEN;

Please don't add code before variable declarations.
-- 
pw-bot: cr