linux-kernel - Re: [PATCH v3] ALSA: hda/tas2781: Fix the ld issue reported by kernel test robot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h61pt6rt.wl-tiwai@suse.de>
Date: Tue, 13 May 2025 07:32:38 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Shenghao Ding <shenghao-ding@...com>
Cc: <broonie@...nel.org>,
	<andriy.shevchenko@...ux.intel.com>,
	<13564923607@....com>,
	<13916275206@....com>,
	<alsa-devel@...a-project.org>,
	<linux-kernel@...r.kernel.org>,
	<baojun.xu@...com>,
	<Baojun.Xu@....com>,
	<jesse-ji@...com>
Subject: Re: [PATCH v3] ALSA: hda/tas2781: Fix the ld issue reported by kernel test robot

On Tue, 13 May 2025 01:48:33 +0200,
Shenghao Ding wrote:
> 
> After commit 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c
> and leverage SND_SOC_TAS2781_FMWLIB")created a separated lib for i2c,
> However, tasdevice_remove() used for not only for I2C but for SPI being
> still in that lib caused ld issue.
> All errors (new ones prefixed by >>):
> >> ld.lld: error: undefined symbol: tasdevice_remove
>    >>> referenced by tas2781_hda.c:33 (sound/pci/hda/tas2781_hda.c:33)
>    >>>               vmlinux.o:(tas2781_hda_remove)
> To fix this issue, the implementation of tasdevice_remove was moved from
> tas2781-comlib-i2c.c to tas2781-comlib.c.
> 
> Fixes: 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")
> Signed-off-by: Shenghao Ding <shenghao-ding@...com>
> 
> ---
> v3:
>  - Drop the report tag in the patch description.
> v2:
>  - put the Fixes tag to point out the commit that introduced the regression
>  - Add compiling error information reported by kernel test robot into patch
>    description.
> v1:
>  - | Reported-by: kernel test robot <lkp@...el.com>
>    | Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505111855.FP2fScKA-lkp@intel.com/__;!!G3vK!U-wdsvrOG1iezggZ55RYi8ikBxMaJD

You dropped again those tags.  These should be put around your
Signed-off-by without quotes.  That is, something like:

Fixes: 9fa6a693ad8d ("....")
Reported-by: kernel test robot <lkp@...el.com>
Closes: https://....
Signed-off-by: Shenghao Ding <shenghao-ding@...com>


thanks,

Takashi