linux-kernel - Re: [PATCH v9 02/19] crypto: acomp - Reinstate non-chained crypto_acomp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCL8Z-XHk4StnvPQ@gondor.apana.org.au>
Date: Tue, 13 May 2025 16:01:43 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, hannes@...xchg.org,
	yosry.ahmed@...ux.dev, nphamcs@...il.com, chengming.zhou@...ux.dev,
	usamaarif642@...il.com, ryan.roberts@....com, 21cnbao@...il.com,
	ying.huang@...ux.alibaba.com, akpm@...ux-foundation.org,
	senozhatsky@...omium.org, linux-crypto@...r.kernel.org,
	davem@...emloft.net, clabbe@...libre.com, ardb@...nel.org,
	ebiggers@...gle.com, surenb@...gle.com, kristen.c.accardi@...el.com,
	vinicius.gomes@...el.com, wajdi.k.feghali@...el.com,
	vinodh.gopal@...el.com
Subject: Re: [PATCH v9 02/19] crypto: acomp - Reinstate non-chained
 crypto_acomp_[de]compress().

On Thu, May 08, 2025 at 12:41:17PM -0700, Kanchana P Sridhar wrote:
>
> diff --git a/crypto/acompress.c b/crypto/acompress.c
> index 82fb3c04e68f..d08e0fe8cd9e 100644
> --- a/crypto/acompress.c
> +++ b/crypto/acompress.c
> @@ -310,21 +310,13 @@ static int acomp_do_req_chain(struct acomp_req *req, bool comp)
>  
>  int crypto_acomp_compress(struct acomp_req *req)
>  {
> -	struct crypto_acomp *tfm = crypto_acomp_reqtfm(req);
> -
> -	if (crypto_acomp_req_chain(tfm) || acomp_request_issg(req))
> -		crypto_acomp_reqtfm(req)->compress(req);
> -	return acomp_do_req_chain(req, true);
> +	return crypto_acomp_reqtfm(req)->compress(req);

That's not right.  Request chaining has already been removed.
What remains is linear address support which you've just removed
with this patch.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt