linux-kernel - Re: [PATCH v1] ALSA: hda/tas2781: Fix the symbol was not declare warning reported by kernel test robot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871pssubn1.wl-tiwai@suse.de>
Date: Tue, 13 May 2025 11:02:10 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Shenghao Ding <shenghao-ding@...com>
Cc: <broonie@...nel.org>,
	<andriy.shevchenko@...ux.intel.com>,
	<13564923607@....com>,
	<13916275206@....com>,
	<alsa-devel@...a-project.org>,
	<linux-kernel@...r.kernel.org>,
	<baojun.xu@...com>,
	<Baojun.Xu@....com>,
	<jesse-ji@...com>,
	kernel test robot
	<lkp@...el.com>
Subject: Re: [PATCH v1] ALSA: hda/tas2781: Fix the symbol was not declare warning reported by kernel test robot

On Tue, 13 May 2025 09:17:21 +0200,
Shenghao Ding wrote:
> 
> After commit 28a09d9e42c5 ("ALSA: hda/tas2781: Create an independent lib
> to save the shared parts for both SPI and I2C driver") created a separated
> lib for both hda-i2c and hda-spi driver, which caused this issue.
> sparse warnings: (new ones prefixed by >>)
> >> sound/pci/hda/tas2781_hda_spi.c:496:25: sparse: sparse: symbol
>    'tas2781_snd_ctls' was not declared. Should it be static?
> >> sound/pci/hda/tas2781_hda_spi.c:505:25: sparse: sparse: symbol
>    'tas2781_prof_ctl' was not declared. Should it be static?
> >> sound/pci/hda/tas2781_hda_spi.c:512:25: sparse: sparse: symbol
>    'tas2781_dsp_ctls' was not declared. Should it be static?
> 
> Fixes: 28a09d9e42c5 ("ALSA: hda/tas2781: Create an independent lib to save the shared parts for both SPI and I2C driver")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505130420.vr9yDI3k-lkp@intel.com/__;!!G3vK!URphGMMfZ2erCLfJdETofl0O1mTSydDLLJ6inMIYWYUDUKYef_IuLvI7pnYj3Mx-4LRIi4BJEw$
> Signed-off-by: Shenghao Ding <shenghao-ding@...com>

Applied now.  Thanks.


Takashi