linux-kernel - Re: [PATCH v2 1/6] dt-bindings: mfd: add bindings for QIXIS CPLD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3xpk6nzqku57i56tzuqsc546rp66upht5wyrcdl7xxnqud2wvf@evakkcowm2it>
Date: Tue, 13 May 2025 12:04:09 +0300
From: Ioana Ciornei <ioana.ciornei@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: lee@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, shawnguo@...nel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, vladimir.oltean@....com
Subject: Re: [PATCH v2 1/6] dt-bindings: mfd: add bindings for QIXIS CPLD

On Mon, May 12, 2025 at 06:54:39PM +0200, Krzysztof Kozlowski wrote:
> On Fri, May 09, 2025 at 06:29:35PM GMT, Ioana Ciornei wrote:
> > This adds device tree bindings for the board management controller -
> 
> "Add devicetree bindings...."
> 
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> 

Ok, sure. Will fix.

> > QIXIS CPLD - found on some Layerscape based boards such as LX2162A-QDS,
> > LX2160AQDS, LS1028AQDS etc.
> > 
> 
> ...
> 
> > +title: NXP's QIXIS CPLD board management controller
> > +
> > +maintainers:
> > +  - Ioana Ciornei <ioana.ciornei@....com>
> > +
> > +description: |
> 
> Do not need '|' unless you need to preserve formatting.

Ok.

> 
> > +  The board management controller found on some Layerscape boards contains
> > +  different IP blocks like GPIO controllers, interrupt controllers, reg-muxes
> > +  etc. The QIXIS CPLD on these boards presents itself as an I2C device.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - fsl,ls1028a-qds-qixis-cpld
> > +      - fsl,lx2160a-qds-qixis-cpld
> > +      - fsl,lx2162a-qds-qixis-cpld
> 
> I think my question why existing compatibles cannot work is still valid.
> If you responded to that and I missed reply, please point me, but I see
> I replied on 7th May and you sent it later - on 9th May.

Sorry, I was under the impression that this message from Vladimir
responded to the question why the compatibles are changed:
	https://lore.kernel.org/all/20250507153811.ukkficut2f3jm2hg@skbuf/

> 
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  "#address-cells":
> > +    const: 1
> > +
> > +  "#size-cells":
> > +    const: 0
> > +
> > +patternProperties:
> > +  '^mux-controller(@[a-f0-9]+)?$':
> 
> Either children have bus addressing or not. This should not be flexible,
> because rarely devices differ. If devices differ, then you need separate
> schema most likely.

Agreed, the intention is to have children with bus addressing only. I
will remove the '?' character from the regex so that it is clear.

Ioana