linux-kernel - Re: [PATCH] driver/infiniband/efa: Fix possible null pointer dereference in `efa_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58e21463-6db8-4e26-b212-590453b1ddbf@linux.dev>
Date: Tue, 13 May 2025 16:31:33 +0300
From: Gal Pressman <gal.pressman@...ux.dev>
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: Michael Margolin <mrgolin@...zon.com>, Yossi Leybovich
 <sleybo@...zon.com>, Jason Gunthorpe <jgg@...pe.ca>,
 Leon Romanovsky <leon@...nel.org>, Shiraz Saleem <shiraz.saleem@...el.com>,
 Steve Wise <larrystevenwise@...il.com>, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver/infiniband/efa: Fix possible null pointer
 dereference in `efa_alloc_pd()`

On 13/05/2025 16:22, Thomas Fourier wrote:
> `efa_alloc_pd()` assumes that `udata` is not null but it seems like
> `__ib_alloc_pd()` in drivers/infiniband/core/verbs.c:279 can call it
> through the `ib_device` interface.  This checks if `udata` is null
> before dereferencing it.
> 
> Fixes: 40909f664d27 ("RDMA/efa: Add EFA verbs implementation")
> Signed-off-by: Thomas Fourier <fourier.thomas@...il.com>

udata will never be NULL since EFA does not support kverbs, and
userspace will always pass udata.

Look at ib_device_check_mandatory().