linux-kernel - Re: [PATCH 1/3] i2c: add init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYB6sjp4PwHumkj1kj48oUzSZOUFQTX1i==P8V2DJBx1A@mail.gmail.com>
Date: Tue, 13 May 2025 15:32:01 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Gabor Juhos <j4g8y7@...il.com>
Cc: Wolfram Sang <wsa@...nel.org>, Andi Shyti <andi.shyti@...nel.org>, 
	Russell King <rmk+kernel@...linux.org.uk>, Andrew Lunn <andrew@...n.ch>, 
	Robert Marko <robert.marko@...tura.hr>, linux-i2c@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Imre Kaloz <kaloz@...nwrt.org>, stable@...r.kernel.org
Subject: Re: [PATCH 1/3] i2c: add init_recovery() callback

Szía Gabor,

köszönöm a patch-et!

On Sun, May 11, 2025 at 3:31 PM Gabor Juhos <j4g8y7@...il.com> wrote:

> Add a new init_recovery() callback to struct 'i2c_bus_recovery_info'
> and modify the i2c_init_recovery() function to call that if specified
> instead of the generic i2c_gpio_init_recovery() function.
>
> This allows controller drivers to skip calling the generic code by
> implementing a dummy callback function, or alternatively to run a
> fine tuned custom implementation.
>
> This is needed for the 'i2c-pxa' driver in order to be able to fix
> a long standing bug for which the fix will be implemented in a
> followup patch.
>
> Cc: stable@...r.kernel.org # 6.3+
> Signed-off-by: Gabor Juhos <j4g8y7@...il.com>
> Signed-off-by: Imre Kaloz <kaloz@...nwrt.org>

Clearly, since the same problems keeps appearing on other
platforms as well, this is the right way to go!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij