linux-kernel - Re: [PATCH v2 4/6] arm64: dts: qcom: qcs615: Add IMEM and PIL info region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76327ba4-a416-41b5-b6ab-d1f9c7b58126@quicinc.com>
Date: Tue, 13 May 2025 10:12:01 +0800
From: Lijuan Gao <quic_lijuang@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>,
        Konrad Dybcio <konradybcio@...nel.org>
CC: <kernel@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/6] arm64: dts: qcom: qcs615: Add IMEM and PIL info
 region



在 5/13/2025 3:10 AM, Konrad Dybcio 写道:
> On 5/12/25 5:20 AM, Lijuan Gao wrote:
>>
>>
>> 在 5/9/2025 4:54 PM, Konrad Dybcio 写道:
>>> On 5/9/25 9:37 AM, Lijuan Gao wrote:
>>>>
>>>>
>>>> 在 5/8/2025 10:41 PM, Konrad Dybcio 写道:
>>>>> On 5/7/25 12:26 PM, Lijuan Gao wrote:
>>>>>> Add a simple-mfd representing IMEM on QCS615 and define the PIL
>>>>>> relocation info region as its child. The PIL region in IMEM is used to
>>>>>> communicate load addresses of remoteproc to post mortem debug tools, so
>>>>>> that these tools can collect ramdumps.
>>>>>>
>>>>>> Signed-off-by: Lijuan Gao <quic_lijuang@...cinc.com>
>>>>>> ---
>>>>>>     arch/arm64/boot/dts/qcom/qcs615.dtsi | 14 ++++++++++++++
>>>>>>     1 file changed, 14 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>>>>> index 53661e3a852e..fefdb0fd66f7 100644
>>>>>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>>>>>> @@ -3266,6 +3266,20 @@ sram@...0000 {
>>>>>>                 reg = <0x0 0x0c3f0000 0x0 0x400>;
>>>>>>             };
>>>>>>     +        sram@...aa000 {
>>>>>> +            compatible = "qcom,qcs615-imem", "syscon", "simple-mfd";
>>>>>> +            reg = <0x0 0x146aa000 0x0 0x1000>;
>>>>>
>>>>> 0x14680000 0x2c000
>>>>
>>>> I checked the latest datasheet, the Shared IMEM address is 0x146aa000 and its size is 0x1000, 0x14680000 is the start address of IMEM layout. The shared IMEM is used for debugging purposes, while the others parts are dedicated.
>>>
>>> Even if we don't use the entirety of it, it's good to describe
>>> the whole block
>>>
>>> Konrad
>>
>> According to the definitions on all existing upstream platforms, this imem points to the shared imem. Should we stay consistent?
> 
> That is because everyone kept copying over whatever the downstream
> kernel did ;)
> 
> Let's describe the whole region - at best, it doesn't hurt
> 
> Konrad

Understood, it will be updated in the next patch.

-- 
Thx and BRs
Lijuan Gao