linux-kernel - Re: [PATCH RFC] leds: leds-lp50xx: Handle reg to get correct multi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAWPR02MB92815DC59F65E90956269EEC9B91A@PAWPR02MB9281.eurprd02.prod.outlook.com>
Date: Wed, 14 May 2025 14:34:12 +0000
From: Johan Adolfsson <Johan.Adolfsson@...s.com>
To: Jacek Anaszewski <jacek.anaszewski@...il.com>, Lee Jones <lee@...nel.org>,
	Pavel Machek <pavel@...nel.org>
CC: "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Kernel
	<Kernel@...s.com>, Johan Adolfsson <Johan.Adolfsson@...s.com>
Subject: Re: [PATCH RFC] leds: leds-lp50xx: Handle reg to get correct
 multi_index

From: Jacek Anaszewski <jacek.anaszewski@...il.com>
Sent: Tuesday, May 13, 2025 21:52
To: Johan Adolfsson; Lee Jones; Pavel Machek
Cc: linux-leds@...r.kernel.org; linux-kernel@...r.kernel.org; Kernel
Subject: Re: [PATCH RFC] leds: leds-lp50xx: Handle reg to get correct multi_index
..
>>                       }
>> +                     ret = fwnode_property_read_u32(led_node, "reg", &multi_index);
>> +                     if (ret) {
>> +                             multi_index = num_colors;
>
>Why not to fail if 'reg' parsing fails?
>It is marked required in DT bindings [0].

I didn't want to start failing if reg is missing since it has never been handled until now, despite what the doc says since 2022...
...

>[0] Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>
>--
>Best regards,
>Jacek Anaszewski

Best regards
/Johan