linux-kernel - Re: [PATCH v2 2/6] dt-bindings: clock: qcom: ipq5018: remove bindings for XO clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DS7PR19MB888352D0B5157990EA5240139D91A@DS7PR19MB8883.namprd19.prod.outlook.com>
Date: Wed, 14 May 2025 12:11:30 +0400
From: George Moussalem <george.moussalem@...look.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Luo Jie <quic_luoj@...cinc.com>,
 Lee Jones <lee@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
 Arnd Bergmann <arnd@...db.de>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: clock: qcom: ipq5018: remove bindings
 for XO clock



On 5/10/25 01:48, Konrad Dybcio wrote:
> On 5/6/25 7:43 AM, George Moussalem via B4 Relay wrote:
>> From: George Moussalem <george.moussalem@...look.com>
>>
>> The XO and its source clock must be always-on and is enabled in the GCC
>> during probe. As such, remove the bindings for them.
>>
>> Signed-off-by: George Moussalem <george.moussalem@...look.com>
>> ---
>>   include/dt-bindings/clock/qcom,gcc-ipq5018.h | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/include/dt-bindings/clock/qcom,gcc-ipq5018.h b/include/dt-bindings/clock/qcom,gcc-ipq5018.h
>> index f3de2fdfeea11f4b8832b75a05e424ca347b3634..d4de5eaffee7b4cb81e0ff2dcbf9e6669c3da8f8 100644
>> --- a/include/dt-bindings/clock/qcom,gcc-ipq5018.h
>> +++ b/include/dt-bindings/clock/qcom,gcc-ipq5018.h
>> @@ -140,8 +140,6 @@
>>   #define GCC_WCSS_DBG_IFC_NTS_BDG_CLK			131
>>   #define GCC_WCSS_DBG_IFC_NTS_CLK			132
>>   #define GCC_WCSS_ECAHB_CLK				133
>> -#define GCC_XO_CLK					134
>> -#define GCC_XO_CLK_SRC					135
>>   #define GMAC0_RX_CLK_SRC				136
>>   #define GMAC0_TX_CLK_SRC				137
>>   #define GMAC1_RX_CLK_SRC				138
> 
> Let's skip this patch - when we add dt-bindings, we promise these values
> will be an ABI, leaving them in there, even if unused, will help
> introducing spurious entries

Understood. Will omit this patch in next version.

Thanks,
George