linux-kernel - Re: [PATCH 6/7] PCI: Remove unnecessary prototype from pci.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f1140397e628cfdf4156f02f5454f844003dc6d.camel@mailbox.org>
Date: Thu, 15 May 2025 15:37:06 +0200
From: Philipp Stanner <phasta@...lbox.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Philipp Stanner
	 <phasta@...nel.org>
Cc: Jonathan Corbet <corbet@....net>, Bjorn Helgaas <bhelgaas@...gle.com>, 
 Mark Brown <broonie@...nel.org>, David Lechner <dlechner@...libre.com>,
 Zijun Hu <quic_zijuhu@...cinc.com>,  Yang Yingliang
 <yangyingliang@...wei.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>,  linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org,  linux-pci@...r.kernel.org
Subject: Re: [PATCH 6/7] PCI: Remove unnecessary prototype from pci.h

On Thu, 2025-05-15 at 16:02 +0300, Andy Shevchenko wrote:
> On Thu, May 15, 2025 at 02:46:04PM +0200, Philipp Stanner wrote:
> > pcim_intx() once was an internal PCI function, but since then has
> > been
> > published and is used by drivers, and, therefore, available in
> > include/linux/pci.h. The function is not used within PCI anymore.
> > 
> > Remove pcim_intx()'s prototype from drivers/pci/pci.h
> 
> Can this be moved up in the series? Or is there other dependencies?
> I.o.w. this
> looks like a leftover from something of the previous work.
> 

That can be moved to anywhere, including a separate patch. It's an
independent patch, a leftover from last year. But it's related to
devres, because it was also added because of the problem with
pcim_enable_device().

P.