linux-kernel - Re: [PATCH 1/2] arm64: dts: st: fix timer used for ticks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86ikm2f0y2.wl-maz@kernel.org>
Date: Thu, 15 May 2025 14:39:01 +0100
From: Marc Zyngier <maz@...nel.org>
To: Patrick Delaunay <patrick.delaunay@...s.st.com>
Cc: Alexandre TORGUE <alexandre.torgue@...s.st.com>,
	Rob Herring
	<robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley
	<conor+dt@...nel.org>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	<devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH 1/2] arm64: dts: st: fix timer used for ticks

On Thu, 15 May 2025 14:12:39 +0100,
Patrick Delaunay <patrick.delaunay@...s.st.com> wrote:
> 
> Remove always-on on generic ARM timer as the clock source provided by
> STGEN is deactivated in low power mode, STOP1 by example.
> 
> Fixes: 5d30d03aaf78 ("arm64: dts: st: introduce stm32mp25 SoCs family")
> Signed-off-by: Patrick Delaunay <patrick.delaunay@...s.st.com>
> ---
> 
>  arch/arm64/boot/dts/st/stm32mp251.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index 8d87865850a7..74c5f85b800f 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -150,7 +150,7 @@ timer {
>  			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
>  			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
>  			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>;
> -		always-on;
> +		arm,no-tick-in-suspend;

That's amusing, because these two properties literally describe
opposite behaviours (from an optimisation to a HW bug).

I'm also pretty sure 99% of the DTs in the tree that have the
always-on property are wrong.

>  	};
>  
>  	soc@0 {

I don't want to sound rude or anything, but the guy you Cc'd on an
@arm.com will not reply (and hasn't been replying for almost 6 years).

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.