linux-kernel - Re: [PATCH] wifi: ath11k: clean-up during wrong ath11k_crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45758365-5f5a-6650-ed30-1c394b9b81de@quicinc.com>
Date: Thu, 15 May 2025 23:06:48 +0530
From: Vasanthakumar Thiagarajan <quic_vthiagar@...cinc.com>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>, <jjohnson@...nel.org>
CC: <~lkcamp/patches@...ts.sr.ht>, <linux-wireless@...r.kernel.org>,
        <ath11k@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: clean-up during wrong ath11k_crypto_mode



On 5/15/2025 6:10 AM, Rodrigo Gobbi wrote:
> if ath11k_crypto_mode is invalid (not ATH11K_CRYPT_MODE_SW/ATH11K_CRYPT_MODE_HW),
> ath11k_core_qmi_firmware_ready() will not undo some actions that was previously
> started/configured. It's reasonable to undo things during this condition, despite
> the value used at ath11k_crypto_mode not being valid in this case.
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
> ---
> Smatch got the following error:
> 
> drivers/net/wireless/ath/ath11k/core.c:2166 ath11k_core_qmi_firmware_ready() warn: missing unwind goto?
> 

This warning message can be included in the commit message itself.

> When the ath11k_crypto_mode, which is a module param, is not
> ATH11K_CRYPT_MODE_SW/HW, clean-up actions are not triggered.
> Considering the whole ath11k_core_qmi_firmware_ready() function,
> during potential errors, those actions are properly triggered.
> I'm suggesting a little change over the default case to clean things up.
> Tks and regards.

This can be dropped as it does not provide any additional information.

Vasanth