linux-kernel - [PATCH] wifi: ath11k: clean-up during wrong ath11k_crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250515004258.87234-1-rodrigo.gobbi.7@gmail.com>
Date: Wed, 14 May 2025 21:40:54 -0300
From: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
To: jjohnson@...nel.org
Cc: ~lkcamp/patches@...ts.sr.ht,
	linux-wireless@...r.kernel.org,
	ath11k@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] wifi: ath11k: clean-up during wrong ath11k_crypto_mode

if ath11k_crypto_mode is invalid (not ATH11K_CRYPT_MODE_SW/ATH11K_CRYPT_MODE_HW),
ath11k_core_qmi_firmware_ready() will not undo some actions that was previously
started/configured. It's reasonable to undo things during this condition, despite
the value used at ath11k_crypto_mode not being valid in this case.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
---
Smatch got the following error:

drivers/net/wireless/ath/ath11k/core.c:2166 ath11k_core_qmi_firmware_ready() warn: missing unwind goto?

When the ath11k_crypto_mode, which is a module param, is not
ATH11K_CRYPT_MODE_SW/HW, clean-up actions are not triggered. 
Considering the whole ath11k_core_qmi_firmware_ready() function,
during potential errors, those actions are properly triggered. 
I'm suggesting a little change over the default case to clean things up.
Tks and regards.
---
 drivers/net/wireless/ath/ath11k/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 2e9f8a5e61e4..fd3017c444a4 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -2163,7 +2163,9 @@ int ath11k_core_qmi_firmware_ready(struct ath11k_base *ab)
 		break;
 	default:
 		ath11k_info(ab, "invalid crypto_mode: %d\n", ath11k_crypto_mode);
-		return -EINVAL;
+		ret = -EINVAL;
+		ath11k_dp_free(ab);
+		goto err_firmware_stop;
 	}
 
 	if (ath11k_frame_mode == ATH11K_HW_TXRX_RAW)
-- 
2.49.0