linux-kernel - Re: 回复: 回复: [PATCH 2/2] hfs: fix to update ctime after rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44bdd2c97a8c91acb4b7e101f85f9a261b6c5cbc.camel@dubeyko.com>
Date: Wed, 14 May 2025 18:10:26 -0700
From: Viacheslav Dubeyko <slava@...eyko.com>
To: 李扬韬 <frank.li@...o.com>,  Viacheslav
 Dubeyko <Slava.Dubeyko@....com>, "glaubitz@...sik.fu-berlin.de"
 <glaubitz@...sik.fu-berlin.de>
Cc: "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, 
 "linux-kernel@...r.kernel.org"
	 <linux-kernel@...r.kernel.org>
Subject: Re: 回复: 回复:  [PATCH 2/2] hfs: fix to update ctime
 after rename

On Sat, 2025-05-10 at 05:31 +0000, 李扬韬 wrote:
> Hi Slava,
> 
> > If I understood correctly "ERROR: access time has changed for file1
> > after remount" means atime has been changed.
> 
> In fact, it seems that it is not the atime that has been changed, but
> the disk atime that has been not changed. 
> The inode in memory has a newer atime, but the atime is not updated
> to the disk when write_inode is executed(hfs has no atime in disk
> format).
> 
> For ERROR: access time has changed for file1 after remount
> 
> Before:
> 	Access:  2025-05-09 14:05:40
> 	Modify:  2025-05-09 14:05:38
> 	Change:  2025-05-09 14:05:38
> 
> After umount&mount:
> 	Access:  2025-05-09 14:05:38		<-- back to mtime
> 	Modify:  2025-05-09 14:05:38
> 	Change:  2025-05-09 14:05:38
> 
> So we get inconsistent results for atime.
> 
> Am I missing something?
> 

This is was my point. We need to make the access time (atime) always
the same as the modification time (mtime) because we cannot save the
atime on disk. This is what I meant by atime == mtime. And this atime
change is happening in HFS driver logic that needs to be corrected.

Thanks,
Slava.