linux-kernel - 回复: 回复: [PATCH 2/2] hfs: fix to update ctime after rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEZPR06MB5269F2CCD9AD085D2712842FE895A@SEZPR06MB5269.apcprd06.prod.outlook.com>
Date: Sat, 10 May 2025 05:31:52 +0000
From: 李扬韬 <frank.li@...o.com>
To: Viacheslav Dubeyko <slava@...eyko.com>, Viacheslav Dubeyko
	<Slava.Dubeyko@....com>, "glaubitz@...sik.fu-berlin.de"
	<glaubitz@...sik.fu-berlin.de>
CC: "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject:
 回复: 回复:  [PATCH 2/2] hfs: fix to update ctime after rename

Hi Slava,

> If I understood correctly "ERROR: access time has changed for file1 after remount" means atime has been changed.

In fact, it seems that it is not the atime that has been changed, but the disk atime that has been not changed. 
The inode in memory has a newer atime, but the atime is not updated to the disk when write_inode is executed(hfs has no atime in disk format).

For ERROR: access time has changed for file1 after remount

Before:
	Access:  2025-05-09 14:05:40
	Modify:  2025-05-09 14:05:38
	Change:  2025-05-09 14:05:38

After umount&mount:
	Access:  2025-05-09 14:05:38		<-- back to mtime
	Modify:  2025-05-09 14:05:38
	Change:  2025-05-09 14:05:38

So we get inconsistent results for atime.

Am I missing something?

Thx,
Yangtao