linux-kernel - Re: [PATCH] scripts: headers_install: fix a false positive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250515-magpie-of-ideal-pluck-c6e323@bergen>
Date: Thu, 15 May 2025 13:32:35 +0200
From: Nicolas Schier <nicolas@...sle.eu>
To: Wen Yang <wen.yang@...ux.dev>
Cc: Masahiro Yamada <masahiroy@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Miguel Ojeda <ojeda@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: headers_install: fix a false positive

On Wed, May 14, 2025 at 12:00:56AM +0800, Wen Yang wrote:
> The current implementation only handles C89 style comments (/*... */) in
> the code, and there are false positives for C99 style comments (//...).
> 
> This patch fixes this issue.
> 
> Signed-off-by: Wen Yang <wen.yang@...ux.dev>
> ---
>  scripts/headers_install.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/headers_install.sh b/scripts/headers_install.sh
> index 6bbccb43f7e7..41722bcc8668 100755
> --- a/scripts/headers_install.sh
> +++ b/scripts/headers_install.sh
> @@ -44,6 +44,7 @@ scripts/unifdef -U__KERNEL__ -D__EXPORTED_HEADERS__ $TMPFILE > $OUTFILE
>  # Remove /* ... */ style comments, and find CONFIG_ references in code
>  configs=$(sed -e '
>  :comment
> +	s://.*::
>  	s:/\*[^*][^*]*:/*:
>  	s:/\*\*\**\([^/]\):/*\1:
>  	t comment
> -- 
> 2.25.1

thanks.  The patch looks good to me, but I cannot find any false
positives.  Have you found any concrete?

Kind regards,
Nicolas